Anvilcraft/Create
1
0
Fork 0
mirror of https://github.com/Creators-of-Create/Create.git synced 2024-11-18 16:02:19 +01:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #4108 from KJP12/mc1.18/forge/pr/memleak

Browse source 
Use a WeakHashMap in WorldAttached to prevent memory leaks
This commit is contained in:
simibubi 2022-12-12 12:39:08 +01:00 committed by GitHub
commit 0b8e6760be
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/main/java/com/simibubi/create/foundation/utility/WorldAttached.java
View file

@ -2,9 +2,9 @@ package com.simibubi.create.foundation.utility;
import java.lang.ref.WeakReference; import java.lang.ref.WeakReference;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.HashMap;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.WeakHashMap;
import java.util.function.BiConsumer; import java.util.function.BiConsumer;
import java.util.function.Consumer; import java.util.function.Consumer;
import java.util.function.Function; import java.util.function.Function;
@ -22,7 +22,9 @@ public class WorldAttached<T> {
public WorldAttached(Function<LevelAccessor, T> factory) { public WorldAttached(Function<LevelAccessor, T> factory) {
this.factory = factory; this.factory = factory;
attached = new HashMap<>(); // Weak key hashmaps prevent worlds not existing anywhere else from leaking memory.
// This is only a fallback in the event that unload events fail to fire for any reason.
attached = new WeakHashMap<>();
allMaps.add(new WeakReference<>(attached)); allMaps.add(new WeakReference<>(attached));
} }