From cbe0f733eee324596c34593cf3eec059988a3b3d Mon Sep 17 00:00:00 2001 From: Aeiou <3160746+AeiouEnigma@users.noreply.github.com> Date: Sun, 12 Jun 2022 13:31:46 -0400 Subject: [PATCH] Fix Starlight crash when moving empty contraptions with downward-facing mechanical pistons. Closes https://github.com/Fabricators-of-Create/Create/issues/360 --- .../components/structureMovement/ContraptionWorld.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/simibubi/create/content/contraptions/components/structureMovement/ContraptionWorld.java b/src/main/java/com/simibubi/create/content/contraptions/components/structureMovement/ContraptionWorld.java index 0699bfc0a..c5e429949 100644 --- a/src/main/java/com/simibubi/create/content/contraptions/components/structureMovement/ContraptionWorld.java +++ b/src/main/java/com/simibubi/create/content/contraptions/components/structureMovement/ContraptionWorld.java @@ -23,8 +23,10 @@ public class ContraptionWorld extends WrappedWorld { this.contraption = contraption; - minY = nextMultipleOf16(contraption.bounds.minY); - height = nextMultipleOf16(contraption.bounds.maxY) - minY; + // Include 1 block above/below contraption height range to avoid certain edge-case Starlight crashes with + // downward-facing mechanical pistons. + minY = nextMultipleOf16(contraption.bounds.minY - 1); + height = nextMultipleOf16(contraption.bounds.maxY + 1) - minY; } // https://math.stackexchange.com/questions/291468