Fix gl error spam

src/main/java/com/jozufozu/flywheel/backend/Backend.java

@@ -21,8 +21,8 @@ import org.lwjgl.opengl.GL;
 import org.lwjgl.opengl.GLCapabilities;
 
 import com.jozufozu.flywheel.backend.core.CrumblingRenderer;
-import com.jozufozu.flywheel.backend.core.WorldContext;
 import com.jozufozu.flywheel.backend.core.WorldTileRenderer;
+import com.jozufozu.flywheel.backend.core.context.WorldContext;
 import com.jozufozu.flywheel.backend.core.shader.WorldProgram;
 import com.jozufozu.flywheel.backend.core.shader.spec.ProgramSpec;
 import com.jozufozu.flywheel.backend.gl.shader.GlProgram;

src/main/java/com/jozufozu/flywheel/backend/core/CrumblingRenderer.java

@@ -1,5 +1,7 @@
 package com.jozufozu.flywheel.backend.core;
 
+import com.jozufozu.flywheel.backend.core.context.WorldContext;
+
 import net.minecraft.util.math.BlockPos;
 
 public class CrumblingRenderer extends WorldTileRenderer<CrumblingProgram> {

src/main/java/com/jozufozu/flywheel/backend/core/FullscreenQuad.java

@@ -0,0 +1,61 @@
+package com.jozufozu.flywheel.backend.core;
+
+import org.lwjgl.opengl.GL20;
+
+import com.jozufozu.flywheel.backend.gl.GlPrimitiveType;
+import com.jozufozu.flywheel.backend.gl.GlVertexArray;
+import com.jozufozu.flywheel.backend.gl.buffer.GlBuffer;
+import com.jozufozu.flywheel.backend.gl.buffer.GlBufferType;
+
+import net.minecraftforge.common.util.Lazy;
+
+public class FullscreenQuad {
+
+	public static final Lazy<FullscreenQuad> INSTANCE = Lazy.of(FullscreenQuad::new);
+
+	private static final float[] vertices = {
+			// pos          // tex
+			-1.0f, -1.0f, 0.0f, 0.0f,
+			1.0f, 1.0f, 1.0f, 1.0f,
+			-1.0f, 1.0f, 0.0f, 1.0f,
+
+			-1.0f, -1.0f, 0.0f, 0.0f,
+			1.0f, -1.0f, 1.0f, 0.0f,
+			1.0f, 1.0f, 1.0f, 1.0f
+	};
+
+	private static final int bufferSize = vertices.length * 4;
+
+	private final GlVertexArray vao;
+	private final GlBuffer vbo;
+
+	private FullscreenQuad() {
+		vbo = new GlBuffer(GlBufferType.ARRAY_BUFFER);
+		vbo.bind();
+		vbo.alloc(bufferSize);
+		vbo.getBuffer(0, bufferSize)
+				.putFloatArray(vertices)
+				.flush();
+
+		vao = new GlVertexArray();
+		vao.bind();
+
+		GL20.glEnableVertexAttribArray(0);
+
+		GL20.glVertexAttribPointer(0, 4, GlPrimitiveType.FLOAT.getGlConstant(), false, 4 * 4, 0);
+
+		vao.unbind();
+		vbo.unbind();
+	}
+
+	public void draw() {
+		vao.bind();
+		GL20.glDrawArrays(GL20.GL_TRIANGLES, 0, 6);
+		vao.unbind();
+	}
+
+	public void delete() {
+		vao.delete();
+		vbo.delete();
+	}
+}

src/main/java/com/jozufozu/flywheel/backend/core/WorldTileRenderer.java

@@ -2,6 +2,7 @@ package com.jozufozu.flywheel.backend.core;
 
 import java.util.ArrayList;
 
+import com.jozufozu.flywheel.backend.core.context.WorldContext;
 import com.jozufozu.flywheel.backend.core.shader.ShaderCallback;
 import com.jozufozu.flywheel.backend.core.shader.WorldProgram;
 import com.jozufozu.flywheel.backend.instancing.InstancedTileRenderer;

src/main/java/com/jozufozu/flywheel/backend/core/context/WorldContext.java

@@ -1,4 +1,4 @@
-package com.jozufozu.flywheel.backend.core;
+package com.jozufozu.flywheel.backend.core.context;
 
 import java.util.EnumMap;
 import java.util.Map;
@@ -12,6 +12,7 @@ import com.jozufozu.flywheel.backend.Backend;
 import com.jozufozu.flywheel.backend.ResourceUtil;
 import com.jozufozu.flywheel.backend.ShaderContext;
 import com.jozufozu.flywheel.backend.ShaderLoader;
+import com.jozufozu.flywheel.backend.core.CrumblingProgram;
 import com.jozufozu.flywheel.backend.core.shader.ExtensibleGlProgram;
 import com.jozufozu.flywheel.backend.core.shader.IMultiProgram;
 import com.jozufozu.flywheel.backend.core.shader.StateSensitiveMultiProgram;

src/main/java/com/jozufozu/flywheel/backend/instancing/InstancedTileRenderer.java

@@ -8,7 +8,7 @@ import java.util.concurrent.ConcurrentHashMap;
 import javax.annotation.Nullable;
 
 import com.jozufozu.flywheel.backend.Backend;
-import com.jozufozu.flywheel.backend.core.WorldContext;
+import com.jozufozu.flywheel.backend.core.context.WorldContext;
 import com.jozufozu.flywheel.backend.core.materials.ModelData;
 import com.jozufozu.flywheel.backend.core.materials.OrientedData;
 import com.jozufozu.flywheel.backend.core.shader.ShaderCallback;

src/main/java/com/simibubi/create/CreateClient.java

@@ -112,7 +112,6 @@ public class CreateClient {
 		PonderIndex.registerTags();
 
 		UIRenderHelper.init();
-		UIRenderHelper.enableStencil();
 
 		IResourceManager resourceManager = Minecraft.getInstance()
 			.getResourceManager();

src/main/java/com/simibubi/create/content/contraptions/components/structureMovement/render/ContraptionRenderDispatcher.java

@@ -15,7 +15,7 @@ import java.util.stream.Stream;
 import org.apache.commons.lang3.tuple.Pair;
 
 import com.jozufozu.flywheel.backend.Backend;
-import com.jozufozu.flywheel.backend.core.WorldContext;
+import com.jozufozu.flywheel.backend.core.context.WorldContext;
 import com.jozufozu.flywheel.backend.loading.ModelTemplate;
 import com.mojang.blaze3d.matrix.MatrixStack;
 import com.simibubi.create.AllMovementBehaviours;

src/main/java/com/simibubi/create/foundation/config/ui/ConfigScreen.java

@@ -8,18 +8,26 @@ import java.util.stream.Collectors;
 import javax.annotation.Nonnull;
 
 import org.apache.commons.lang3.StringUtils;
+import org.lwjgl.opengl.GL11;
+import org.lwjgl.opengl.GL20;
+import org.lwjgl.opengl.GL30;
 
+import com.jozufozu.flywheel.backend.Backend;
 import com.mojang.blaze3d.matrix.MatrixStack;
 import com.simibubi.create.AllBlocks;
 import com.simibubi.create.content.contraptions.relays.elementary.CogWheelBlock;
 import com.simibubi.create.foundation.gui.AbstractSimiScreen;
 import com.simibubi.create.foundation.gui.GuiGameElement;
 import com.simibubi.create.foundation.gui.StencilElement;
+import com.simibubi.create.foundation.gui.UIRenderHelper;
 import com.simibubi.create.foundation.utility.animation.Force;
 import com.simibubi.create.foundation.utility.animation.PhysicalFloat;
 
 import net.minecraft.block.BlockState;
+import net.minecraft.client.Minecraft;
 import net.minecraft.client.gui.screen.Screen;
+import net.minecraft.client.shader.Framebuffer;
+import net.minecraft.client.shader.FramebufferConstants;
 import net.minecraft.util.Direction;
 
 public abstract class ConfigScreen extends AbstractSimiScreen {
@@ -83,7 +91,35 @@ public abstract class ConfigScreen extends AbstractSimiScreen {
 	}
 
 	@Override
-	protected void renderWindow(MatrixStack ms, int mouseX, int mouseY, float partialTicks) {}
+	protected void prepareFrame() {
+		Framebuffer thisBuffer = UIRenderHelper.framebuffer;
+		Framebuffer mainBuffer = Minecraft.getInstance().getFramebuffer();
+
+		Backend.compat.fbo.bindFramebuffer(GL30.GL_READ_FRAMEBUFFER, mainBuffer.framebufferObject);
+		Backend.compat.fbo.bindFramebuffer(GL30.GL_DRAW_FRAMEBUFFER, thisBuffer.framebufferObject);
+		Backend.compat.blit.blitFramebuffer(0, 0, mainBuffer.framebufferWidth, mainBuffer.framebufferHeight, 0, 0, mainBuffer.framebufferWidth, mainBuffer.framebufferHeight, GL30.GL_COLOR_BUFFER_BIT, GL20.GL_LINEAR);
+
+		Backend.compat.fbo.bindFramebuffer(FramebufferConstants.FRAME_BUFFER, thisBuffer.framebufferObject);
+		GL11.glClear(GL30.GL_STENCIL_BUFFER_BIT | GL30.GL_DEPTH_BUFFER_BIT);
+
+	}
+
+	@Override
+	protected void endFrame() {
+
+		Framebuffer thisBuffer = UIRenderHelper.framebuffer;
+		Framebuffer mainBuffer = Minecraft.getInstance().getFramebuffer();
+
+		Backend.compat.fbo.bindFramebuffer(GL30.GL_READ_FRAMEBUFFER, thisBuffer.framebufferObject);
+		Backend.compat.fbo.bindFramebuffer(GL30.GL_DRAW_FRAMEBUFFER, mainBuffer.framebufferObject);
+		Backend.compat.blit.blitFramebuffer(0, 0, mainBuffer.framebufferWidth, mainBuffer.framebufferHeight, 0, 0, mainBuffer.framebufferWidth, mainBuffer.framebufferHeight, GL30.GL_COLOR_BUFFER_BIT, GL20.GL_LINEAR);
+
+		Backend.compat.fbo.bindFramebuffer(FramebufferConstants.FRAME_BUFFER, mainBuffer.framebufferObject);
+	}
+
+	@Override
+	protected void renderWindow(MatrixStack ms, int mouseX, int mouseY, float partialTicks) {
+	}
 
 	@Override
 	public boolean mouseScrolled(double mouseX, double mouseY, double delta) {

src/main/java/com/simibubi/create/foundation/gui/AbstractSimiScreen.java

@@ -48,15 +48,25 @@ public abstract class AbstractSimiScreen extends Screen {
 
 		ms.push();
 
+		prepareFrame();
+
 		renderWindowBackground(ms, mouseX, mouseY, partialTicks);
 		renderWindow(ms, mouseX, mouseY, partialTicks);
 		for (Widget widget : widgets)
 			widget.render(ms, mouseX, mouseY, partialTicks);
 		renderWindowForeground(ms, mouseX, mouseY, partialTicks);
 
+		endFrame();
+
 		ms.pop();
 	}
 
+	protected void prepareFrame() {
+	}
+
+	protected void endFrame() {
+	}
+
 	protected void renderWindowBackground(MatrixStack ms, int mouseX, int mouseY, float partialTicks) {
 		renderBackground(ms);
 	}

src/main/java/com/simibubi/create/foundation/gui/StencilElement.java

@@ -47,5 +47,6 @@ public abstract class StencilElement extends RenderElement {
 
 	protected void cleanUp(MatrixStack ms) {
 		GL11.glDisable(GL11.GL_STENCIL_TEST);
+
 	}
 }

src/main/java/com/simibubi/create/foundation/gui/UIRenderHelper.java

@@ -1,6 +1,6 @@
 package com.simibubi.create.foundation.gui;
 
-import java.awt.Color;
+import java.awt.*;
 
 import javax.annotation.Nonnull;
 
@@ -25,21 +25,31 @@ import net.minecraftforge.fml.client.gui.GuiUtils;
 
 public class UIRenderHelper {
 
-	public static void enableStencil() {
-		RenderSystem.recordRenderCall(() -> Minecraft.getInstance().getFramebuffer().enableStencil());
-	}
-
+	/**
+	 * An FBO that has a stencil buffer for use wherever stencil are necessary. Forcing the main FBO to have a stencil
+	 * buffer will cause GL error spam when using fabulous graphics.
+	 */
 	public static Framebuffer framebuffer;
 
+	public static void updateWindowSize(MainWindow mainWindow) {
+		if (framebuffer != null)
+			framebuffer.func_216491_a(mainWindow.getFramebufferWidth(), mainWindow.getFramebufferHeight(), Minecraft.IS_RUNNING_ON_MAC);
+	}
+
 	public static void init() {
 		RenderSystem.recordRenderCall(() -> {
 			MainWindow mainWindow = Minecraft.getInstance()
 					.getWindow();
-			framebuffer = new Framebuffer(mainWindow.getFramebufferWidth(), mainWindow.getFramebufferHeight(), true,
+			framebuffer = createFramebuffer(mainWindow);
+		});
+	}
+
+	private static Framebuffer createFramebuffer(MainWindow mainWindow) {
+		Framebuffer framebuffer = new Framebuffer(mainWindow.getFramebufferWidth(), mainWindow.getFramebufferHeight(), true,
 				Minecraft.IS_RUNNING_ON_MAC);
 		framebuffer.setFramebufferColor(0, 0, 0, 0);
 		framebuffer.enableStencil();
-		});
+		return framebuffer;
 	}
 
 	public static void drawFramebuffer(float alpha) {
@@ -70,10 +80,10 @@ public class UIRenderHelper {
 	}
 
 	public static void streak(MatrixStack ms, float angle, int x, int y, int breadth, int length) {streak(ms, angle, x, y, breadth, length, Theme.i(Theme.Key.STREAK));}
-
 	// angle in degrees; 0° -> fading to the right
 	// x and y specify the middle point of the starting edge
 	// breadth is the total width of the streak
+
 	public static void streak(MatrixStack ms, float angle, int x, int y, int breadth, int length, int color) {
 		int a1 = 0xa0 << 24;
 		int a2 = 0x80 << 24;

src/main/java/com/simibubi/create/foundation/mixin/WindowResizeMixin.java

@@ -22,8 +22,7 @@ public class WindowResizeMixin {
 
 	@Inject(at = @At("TAIL"), method = "updateWindowSize")
 	private void updateWindowSize(CallbackInfo ci) {
-		if (UIRenderHelper.framebuffer != null)
-			UIRenderHelper.framebuffer.func_216491_a(mainWindow.getFramebufferWidth(), mainWindow.getFramebufferHeight(), Minecraft.IS_RUNNING_ON_MAC);
+		UIRenderHelper.updateWindowSize(mainWindow);
 	}
 
 }

src/main/java/com/simibubi/create/foundation/render/effects/EffectsHandler.java

@@ -9,10 +9,7 @@ import org.lwjgl.opengl.GL20;
 import org.lwjgl.opengl.GL30;
 
 import com.jozufozu.flywheel.backend.Backend;
-import com.jozufozu.flywheel.backend.gl.GlPrimitiveType;
-import com.jozufozu.flywheel.backend.gl.GlVertexArray;
-import com.jozufozu.flywheel.backend.gl.buffer.GlBuffer;
-import com.jozufozu.flywheel.backend.gl.buffer.GlBufferType;
+import com.jozufozu.flywheel.backend.core.FullscreenQuad;
 import com.jozufozu.flywheel.util.RenderUtil;
 import com.simibubi.create.foundation.render.AllProgramSpecs;
 import com.simibubi.create.foundation.utility.AnimationTickHolder;
@@ -52,23 +49,8 @@ public class EffectsHandler {
 		return Minecraft.getInstance().gameRenderer.getFarPlaneDistance() * 4;
 	}
 
-	public static final float[] vertices = {
-			// pos        // tex
-			-1.0f, -1.0f, 0.0f, 0.0f,
-			1.0f, 1.0f, 1.0f, 1.0f,
-			-1.0f, 1.0f, 0.0f, 1.0f,
-
-			-1.0f, -1.0f, 0.0f, 0.0f,
-			1.0f, -1.0f, 1.0f, 0.0f,
-			1.0f, 1.0f, 1.0f, 1.0f
-	};
-
-	private static final int bufferSize = vertices.length * 4;
 
 	private final Framebuffer framebuffer;
-	private final GlVertexArray vao;
-
-	private final GlBuffer vbo;
 
 	private final ArrayList<FilterSphere> spheres;
 
@@ -78,23 +60,6 @@ public class EffectsHandler {
 		Framebuffer render = Minecraft.getInstance().getFramebuffer();
 		framebuffer = new Framebuffer(render.framebufferWidth, render.framebufferHeight, false, Minecraft.IS_RUNNING_ON_MAC);
 
-		vbo = new GlBuffer(GlBufferType.ARRAY_BUFFER);
-		vbo.bind();
-		vbo.alloc(bufferSize);
-		vbo.getBuffer(0, bufferSize)
-				.putFloatArray(vertices)
-				.flush();
-
-		vao = new GlVertexArray();
-		vao.bind();
-
-		GL20.glEnableVertexAttribArray(0);
-
-		GL20.glVertexAttribPointer(0, 4, GlPrimitiveType.FLOAT.getGlConstant(), false, 4 * 4, 0);
-
-		vao.unbind();
-		vbo.unbind();
-
 	}
 
 	public void addSphere(FilterSphere sphere) {
@@ -155,9 +120,7 @@ public class EffectsHandler {
 		program.setFarPlane(getFarPlane());
 		program.setNearPlane(getNearPlane());
 
-		vao.bind();
-		GL20.glDrawArrays(GL20.GL_TRIANGLES, 0, 6);
-		vao.unbind();
+		FullscreenQuad.INSTANCE.get().draw();
 
 		program.bindColorTexture(0);
 		program.bindDepthTexture(0);
@@ -174,9 +137,6 @@ public class EffectsHandler {
 
 	public void delete() {
 		framebuffer.deleteFramebuffer();
-
-		vao.delete();
-		vbo.delete();
 	}
 
 	private void prepFramebufferSize() {