From e55ae22d7d3e17b45be8b86c285fcfa3dd7dc01d Mon Sep 17 00:00:00 2001
From: PepperBell <44146161+PepperCode1@users.noreply.github.com>
Date: Thu, 17 Jun 2021 14:43:40 -0700
Subject: [PATCH] Fix fluid tank render boxes

- Update render box on client TE initialization and update packet
- Resolves #1669
---
 .../tank/FluidTankConnectivityHandler.java    |  6 ++---
 .../fluids/tank/FluidTankRenderer.java        |  2 +-
 .../fluids/tank/FluidTankTileEntity.java      | 22 ++++++++++++-------
 .../tileEntity/SmartTileEntity.java           |  2 --
 4 files changed, 18 insertions(+), 14 deletions(-)

diff --git a/src/main/java/com/simibubi/create/content/contraptions/fluids/tank/FluidTankConnectivityHandler.java b/src/main/java/com/simibubi/create/content/contraptions/fluids/tank/FluidTankConnectivityHandler.java
index 0c0c8f6efc..39b694816a 100644
--- a/src/main/java/com/simibubi/create/content/contraptions/fluids/tank/FluidTankConnectivityHandler.java
+++ b/src/main/java/com/simibubi/create/content/contraptions/fluids/tank/FluidTankConnectivityHandler.java
@@ -199,7 +199,7 @@ public class FluidTankConnectivityHandler {
 
 		if (simulate)
 			return amount;
-		
+
 		boolean opaque = false;
 
 		for (int yOffset = 0; yOffset < height; yOffset++) {
@@ -234,7 +234,7 @@ public class FluidTankConnectivityHandler {
 				}
 			}
 		}
-		
+
 		te.setWindows(!opaque);
 
 		return amount;
@@ -281,7 +281,7 @@ public class FluidTankConnectivityHandler {
 					if (!toDistribute.isEmpty() && tankAt != te) {
 						FluidStack copy = toDistribute.copy();
 						FluidTank tankInventory = tankAt.tankInventory;
-						if (tankInventory.isEmpty() && tankInventory instanceof CreativeSmartFluidTank) 
+						if (tankInventory.isEmpty() && tankInventory instanceof CreativeSmartFluidTank)
 							((CreativeSmartFluidTank) tankInventory).setContainedFluid(toDistribute);
 						else {
 							int split = Math.min(maxCapacity, toDistribute.getAmount());
diff --git a/src/main/java/com/simibubi/create/content/contraptions/fluids/tank/FluidTankRenderer.java b/src/main/java/com/simibubi/create/content/contraptions/fluids/tank/FluidTankRenderer.java
index 2818b3a6f7..c3d51df677 100644
--- a/src/main/java/com/simibubi/create/content/contraptions/fluids/tank/FluidTankRenderer.java
+++ b/src/main/java/com/simibubi/create/content/contraptions/fluids/tank/FluidTankRenderer.java
@@ -25,7 +25,7 @@ public class FluidTankRenderer extends SafeTileEntityRenderer<FluidTankTileEntit
 		if (!te.window)
 			return;
 
-		InterpolatedChasingValue fluidLevel = te.fluidLevel;
+		InterpolatedChasingValue fluidLevel = te.getFluidLevel();
 		if (fluidLevel == null)
 			return;
 
diff --git a/src/main/java/com/simibubi/create/content/contraptions/fluids/tank/FluidTankTileEntity.java b/src/main/java/com/simibubi/create/content/contraptions/fluids/tank/FluidTankTileEntity.java
index ccb7403ba3..6b38d00f2c 100644
--- a/src/main/java/com/simibubi/create/content/contraptions/fluids/tank/FluidTankTileEntity.java
+++ b/src/main/java/com/simibubi/create/content/contraptions/fluids/tank/FluidTankTileEntity.java
@@ -56,7 +56,8 @@ public class FluidTankTileEntity extends SmartTileEntity implements IHaveGoggleI
 	protected boolean queuedSync;
 
 	// For rendering purposes only
-	InterpolatedChasingValue fluidLevel;
+	private InterpolatedChasingValue fluidLevel;
+	private AxisAlignedBB renderBoundingBox;
 
 	public FluidTankTileEntity(TileEntityType<?> tileEntityTypeIn) {
 		super(tileEntityTypeIn);
@@ -114,6 +115,8 @@ public class FluidTankTileEntity extends SmartTileEntity implements IHaveGoggleI
 	public void initialize() {
 		super.initialize();
 		sendData();
+		if (world.isRemote)
+			updateRenderBoundingBox();
 	}
 
 	private void onPositionChanged() {
@@ -286,18 +289,20 @@ public class FluidTankTileEntity extends SmartTileEntity implements IHaveGoggleI
 		return isController() ? pos : controller;
 	}
 
-	private AxisAlignedBB cachedBoundingBox;
+	public void updateRenderBoundingBox() {
+		if (isController())
+			renderBoundingBox = super.getRenderBoundingBox().expand(width - 1, height - 1, width - 1);
+		else
+			renderBoundingBox = super.getRenderBoundingBox();
+	}
 
 	@Override
 	@OnlyIn(Dist.CLIENT)
 	public AxisAlignedBB getRenderBoundingBox() {
-		if (cachedBoundingBox == null) {
-			if (isController())
-				cachedBoundingBox = super.getRenderBoundingBox().expand(width - 1, height - 1, width - 1);
-			else
-				cachedBoundingBox = super.getRenderBoundingBox();
+		if (renderBoundingBox == null) {
+			renderBoundingBox = super.getRenderBoundingBox();
 		}
-		return cachedBoundingBox;
+		return renderBoundingBox;
 	}
 
 	@Override
@@ -367,6 +372,7 @@ public class FluidTankTileEntity extends SmartTileEntity implements IHaveGoggleI
 				world.notifyBlockUpdate(getPos(), getBlockState(), getBlockState(), 16);
 			if (isController())
 				tankInventory.setCapacity(getCapacityMultiplier() * getTotalTankSize());
+			updateRenderBoundingBox();
 		}
 		if (isController()) {
 			float fillState = getFillState();
diff --git a/src/main/java/com/simibubi/create/foundation/tileEntity/SmartTileEntity.java b/src/main/java/com/simibubi/create/foundation/tileEntity/SmartTileEntity.java
index bee1a0f3e1..b242a38f3e 100644
--- a/src/main/java/com/simibubi/create/foundation/tileEntity/SmartTileEntity.java
+++ b/src/main/java/com/simibubi/create/foundation/tileEntity/SmartTileEntity.java
@@ -8,13 +8,11 @@ import java.util.function.Consumer;
 
 import com.simibubi.create.content.schematics.ItemRequirement;
 import com.simibubi.create.foundation.tileEntity.behaviour.BehaviourType;
-
 import com.simibubi.create.foundation.utility.IPartialSafeNBT;
 
 import net.minecraft.block.BlockState;
 import net.minecraft.nbt.CompoundNBT;
 import net.minecraft.tileentity.ITickableTileEntity;
-import net.minecraft.tileentity.TileEntity;
 import net.minecraft.tileentity.TileEntityType;
 import net.minecraftforge.common.capabilities.Capability;
 import net.minecraftforge.fluids.capability.CapabilityFluidHandler;