From 592aabf62771e4da08b7118c4fefe3960822de94 Mon Sep 17 00:00:00 2001 From: SenseiKiwi Date: Thu, 3 Jul 2014 17:32:40 -0400 Subject: [PATCH] Minor Change Added a comment in PocketManager to explain why we don't unregister pocket dimensions with Forge when we delete them. --- .../StevenDimDoors/mod_pocketDim/core/PocketManager.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/main/java/StevenDimDoors/mod_pocketDim/core/PocketManager.java b/src/main/java/StevenDimDoors/mod_pocketDim/core/PocketManager.java index acb6ed98..7c7c3e0d 100644 --- a/src/main/java/StevenDimDoors/mod_pocketDim/core/PocketManager.java +++ b/src/main/java/StevenDimDoors/mod_pocketDim/core/PocketManager.java @@ -317,6 +317,11 @@ public class PocketManager { deleteDimensionFiles(dimension); } + // Note: We INTENTIONALLY don't unregister the dimensions that we + // delete with Forge. Instead, we keep them registered to stop Forge + // from reallocating those IDs to other mods such as Mystcraft. This + // is to prevent bugs. Blacklisted dimensions are still properly + // unregistered when the server shuts down. dimensionIDBlackList.add(dimension.id); deleteDimensionData(dimension); return true;