Anvilcraft/buildcraft
3
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix fuel burning mechanic in EngineIron

Browse source 
Old implementation was not as intended I think. For example, lava as fuel should have outputted 20000 MJ, but actually outputted 20980 MJ.
This was because burnTime's value went 20,19,...2,1,0,20 - so that it had actually outputted 21 MJ for each amount of fuel.
Also, when the last amount of fuel was burned, burnTime would be 20 but fuel would be null, and so would currentFuel so that the last cycle was skipped.
So the actual output of some fuel was:
powerPerCycle * ((amount - 1) * (totalBurnTime/1000 + 1) + 1).
There probably are better ways to fix it but this is what seemed best to me.
This commit is contained in:
snyke7 2013-01-21 14:27:38 +01:00
parent d7e06e07a3
commit 1afcf370b5
1 changed files with 15 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
common/buildcraft/energy/EngineIron.java
View file

@ -37,6 +37,7 @@ public class EngineIron extends Engine {
int heat = 0; int heat = 0;
private LiquidTank fuelTank; private LiquidTank fuelTank;
private LiquidTank coolantTank; private LiquidTank coolantTank;
private IronEngineFuel currentFuel = null;
public int penaltyCooling = 0; public int penaltyCooling = 0;
@ -92,7 +93,9 @@ public class EngineIron extends Engine {
public void burn() { public void burn() {
currentOutput = 0; currentOutput = 0;
LiquidStack fuel = this.fuelTank.getLiquid(); LiquidStack fuel = this.fuelTank.getLiquid();
IronEngineFuel currentFuel = IronEngineFuel.getFuelForLiquid(fuel); if(currentFuel == null) {
currentFuel = IronEngineFuel.getFuelForLiquid(fuel);
}
if (currentFuel == null) if (currentFuel == null)
return; return;
@ -104,13 +107,18 @@ public class EngineIron extends Engine {
if (burnTime > 0 || fuel.amount > 0) { if (burnTime > 0 || fuel.amount > 0) {
if (burnTime > 0) { if (burnTime > 0) {
burnTime--; burnTime--;
} else {
if (--fuel.amount <= 0) {
fuelTank.setLiquid(null);
}
burnTime = currentFuel.totalBurningTime / LiquidContainerRegistry.BUCKET_VOLUME;
} }
if (burnTime <= 0) {
if(fuel != null) {
if (--fuel.amount <= 0) {
fuelTank.setLiquid(null);
}
burnTime = currentFuel.totalBurningTime / LiquidContainerRegistry.BUCKET_VOLUME;
} else {
currentFuel = null;
return;
}
}
currentOutput = currentFuel.powerPerCycle; currentOutput = currentFuel.powerPerCycle;
addEnergy(currentFuel.powerPerCycle); addEnergy(currentFuel.powerPerCycle);
heat += currentFuel.powerPerCycle; heat += currentFuel.powerPerCycle;