From b9d8e00f4b1fd4ceaeab4498a737c80a0181ab49 Mon Sep 17 00:00:00 2001 From: Pahimar Date: Sat, 21 May 2016 07:43:14 -0400 Subject: [PATCH] Invert some logic that was causing crashes when saving player knowledge to disk --- .../pahimar/ee3/knowledge/PlayerKnowledgeRegistry.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/main/java/com/pahimar/ee3/knowledge/PlayerKnowledgeRegistry.java b/src/main/java/com/pahimar/ee3/knowledge/PlayerKnowledgeRegistry.java index 3930f29c..6ff91b06 100644 --- a/src/main/java/com/pahimar/ee3/knowledge/PlayerKnowledgeRegistry.java +++ b/src/main/java/com/pahimar/ee3/knowledge/PlayerKnowledgeRegistry.java @@ -102,9 +102,11 @@ public class PlayerKnowledgeRegistry { // Save every currently loaded player knowledge to file for (String playerName : playerKnowledgeMap.keySet()) { - File playerKnowledgeFile = getPlayerKnowledgeFile(playerName); - if (playerKnowledgeFile != null) { - SerializationHelper.writeJsonFile(playerKnowledgeFile, SerializationHelper.GSON.toJson(playerKnowledgeMap.get(playerName))); + if (playerName != null && !playerName.isEmpty()) { + File playerKnowledgeFile = getPlayerKnowledgeFile(playerName); + if (playerKnowledgeFile != null) { + SerializationHelper.writeJsonFile(playerKnowledgeFile, SerializationHelper.GSON.toJson(playerKnowledgeMap.get(playerName))); + } } } } @@ -158,7 +160,7 @@ public class PlayerKnowledgeRegistry { */ private static File getPlayerKnowledgeFile(String playerName) { - if (playerName != null && playerName.isEmpty()) { + if (playerName != null && !playerName.isEmpty()) { return new File(Files.playerDataDirectory, "knowledge" + File.separator + "transmutation" + File.separator + playerName + ".json"); } else {