MirrorHub/bitwarden_rs
0
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden synced 2024-11-12 13:01:51 +01:00
Code Issues Releases Wiki Activity

Error on invalid collection ID in post_collections_admin

Browse source
This commit is contained in:
Miroslav Prasil 2018-05-11 11:45:55 +01:00
parent e5c9d19e25
commit 9cf449e1c5
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/api/core/ciphers.rs
View file

@ -322,7 +322,7 @@ fn post_collections_admin(uuid: String, data: Json<CollectionsAdminData>, header
for collection in posted_collections.symmetric_difference(&current_collections) { for collection in posted_collections.symmetric_difference(&current_collections) {
match Collection::find_by_uuid(&collection, &conn) { match Collection::find_by_uuid(&collection, &conn) {
None => (), // Does not exist, what now? None => err!("Invalid collection ID provided"),
Some(collection) => { Some(collection) => {
if collection.is_writable_by_user(&headers.user.uuid, &conn) { if collection.is_writable_by_user(&headers.user.uuid, &conn) {
if posted_collections.contains(&collection.uuid) { // Add to collection if posted_collections.contains(&collection.uuid) { // Add to collection
@ -330,6 +330,8 @@ fn post_collections_admin(uuid: String, data: Json<CollectionsAdminData>, header
} else { // Remove from collection } else { // Remove from collection
CollectionCipher::delete(&cipher.uuid, &collection.uuid, &conn); CollectionCipher::delete(&cipher.uuid, &collection.uuid, &conn);
} }
} else {
err!("No rights to modify the collection")
} }
} }
} }