0
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden synced 2024-06-28 00:38:23 +02:00
bitwarden_rs/src
Matlink 7c3cad197c
Fix #3624: fix manager permission within groups (#3754)
* Fix #3624: fix manager permission within groups

* Query returns UUID only

* Fix issue when user is manager and in a group having access to all collections

* optimize condition check

* fix(groups): renaming and optimizations

* fix: wrong organization group membership detection

* Simplify group membership check

Co-authored-by: Stefan Melmuk <509385+stefan0xC@users.noreply.github.com>

* Remove unused statement

* improve check if the user has access via groups

instead of returning the two lists of member ids and later checking if
they contain the uuid of the current user, we really only care if
the current user has full access via a group or if they have
access to a given collection via a group

* improve comments for get_org_collections_details

* small refactor to make it easier to review

* fix(groups): query full access via group only when necessary

Co-authored-by: Mathijs van Veluw <black.dex@gmail.com>

* chore(fmt): apply rustfmt

---------

Co-authored-by: Stefan Melmuk <509385+stefan0xC@users.noreply.github.com>
Co-authored-by: Stefan Melmuk <stefan.melmuk@gmail.com>
Co-authored-by: Mathijs van Veluw <black.dex@gmail.com>
2024-03-17 22:11:34 +01:00
..
api Fix #3624: fix manager permission within groups (#3754) 2024-03-17 22:11:34 +01:00
db Fix #3624: fix manager permission within groups (#3754) 2024-03-17 22:11:34 +01:00
static Small improvements around email change (#4415) 2024-03-17 19:55:03 +01:00
auth.rs Improve JWT key initialization and avoid saving public key (#4085) 2024-03-17 15:11:20 +01:00
config.rs Remove custom WebSocket code (#4001) 2024-03-17 19:52:55 +01:00
crypto.rs Remove get_random_64() 2022-11-13 10:03:06 +01:00
error.rs Remove custom WebSocket code (#4001) 2024-03-17 19:52:55 +01:00
mail.rs Add Protected Actions Check (#4067) 2023-11-12 22:15:44 +01:00
main.rs refactor: replace panic with a graceful exit (#4402) 2024-03-17 19:53:41 +01:00
ratelimit.rs Basic ratelimit for user login (including 2FA) and admin login 2021-12-22 21:48:49 +01:00
util.rs Improve JWT key initialization and avoid saving public key (#4085) 2024-03-17 15:11:20 +01:00