From 07bb369c5cee46fba463f94dfb95151f46d2c8f9 Mon Sep 17 00:00:00 2001
From: Matthias Ahouansou <matthias@ahouansou.cz>
Date: Tue, 5 Mar 2024 20:20:19 +0000
Subject: [PATCH] perf: remove unnecessary async

---
 src/api/client_server/sync.rs | 66 ++++++++++++++---------------------
 src/service/users/mod.rs      |  6 ++--
 2 files changed, 30 insertions(+), 42 deletions(-)

diff --git a/src/api/client_server/sync.rs b/src/api/client_server/sync.rs
index 5ac00c60..c510f5f5 100644
--- a/src/api/client_server/sync.rs
+++ b/src/api/client_server/sync.rs
@@ -1197,14 +1197,11 @@ pub async fn sync_events_v4_route(
 
     if globalsince == 0 {
         if let Some(conn_id) = &body.conn_id {
-            services()
-                .users
-                .forget_sync_request_connection(
-                    sender_user.clone(),
-                    sender_device.clone(),
-                    conn_id.clone(),
-                )
-                .await
+            services().users.forget_sync_request_connection(
+                sender_user.clone(),
+                sender_device.clone(),
+                conn_id.clone(),
+            )
         }
     }
 
@@ -1474,17 +1471,14 @@ pub async fn sync_events_v4_route(
         );
 
         if let Some(conn_id) = &body.conn_id {
-            services()
-                .users
-                .update_sync_known_rooms(
-                    sender_user.clone(),
-                    sender_device.clone(),
-                    conn_id.clone(),
-                    list_id,
-                    new_known_rooms,
-                    globalsince,
-                )
-                .await;
+            services().users.update_sync_known_rooms(
+                sender_user.clone(),
+                sender_device.clone(),
+                conn_id.clone(),
+                list_id,
+                new_known_rooms,
+                globalsince,
+            );
         }
     }
 
@@ -1516,29 +1510,23 @@ pub async fn sync_events_v4_route(
     }
 
     if let Some(conn_id) = &body.conn_id {
-        services()
-            .users
-            .update_sync_known_rooms(
-                sender_user.clone(),
-                sender_device.clone(),
-                conn_id.clone(),
-                "subscriptions".to_owned(),
-                known_subscription_rooms,
-                globalsince,
-            )
-            .await;
+        services().users.update_sync_known_rooms(
+            sender_user.clone(),
+            sender_device.clone(),
+            conn_id.clone(),
+            "subscriptions".to_owned(),
+            known_subscription_rooms,
+            globalsince,
+        );
     }
 
     if let Some(conn_id) = &body.conn_id {
-        services()
-            .users
-            .update_sync_subscriptions(
-                sender_user.clone(),
-                sender_device.clone(),
-                conn_id.clone(),
-                body.room_subscriptions,
-            )
-            .await;
+        services().users.update_sync_subscriptions(
+            sender_user.clone(),
+            sender_device.clone(),
+            conn_id.clone(),
+            body.room_subscriptions,
+        );
     }
 
     let mut rooms = BTreeMap::new();
diff --git a/src/service/users/mod.rs b/src/service/users/mod.rs
index c83463ed..fb983a41 100644
--- a/src/service/users/mod.rs
+++ b/src/service/users/mod.rs
@@ -45,7 +45,7 @@ impl Service {
         self.db.exists(user_id)
     }
 
-    pub async fn forget_sync_request_connection(
+    pub fn forget_sync_request_connection(
         &self,
         user_id: OwnedUserId,
         device_id: OwnedDeviceId,
@@ -186,7 +186,7 @@ impl Service {
         cached.known_rooms.clone()
     }
 
-    pub async fn update_sync_subscriptions(
+    pub fn update_sync_subscriptions(
         &self,
         user_id: OwnedUserId,
         device_id: OwnedDeviceId,
@@ -212,7 +212,7 @@ impl Service {
         cached.subscriptions = subscriptions;
     }
 
-    pub async fn update_sync_known_rooms(
+    pub fn update_sync_known_rooms(
         &self,
         user_id: OwnedUserId,
         device_id: OwnedDeviceId,