MirrorHub/construct
0
0
Fork 0
mirror of https://github.com/matrix-construct/construct synced 2024-11-19 00:10:59 +01:00
Code Issues Releases Wiki Activity

ircd::db: Disable use of rocksdb KeyMayExist in db::has() due to regression.

Browse source
This commit is contained in:
Jason Volk 2018-10-16 02:20:49 -07:00
parent 0ad41ea0ff
commit 167eb18470
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ircd/db.cc
View file

@ -7992,6 +7992,10 @@ ircd::db::has(column &column,
database::column &c(column); database::column &c(column);
// Perform a co-RP query to the filtration // Perform a co-RP query to the filtration
/*
// NOTE disabled for rocksdb >= v5.15 due to a regression
// where rocksdb does not init SuperVersion data in the column
// family handle and this codepath triggers null derefs and ub.
if(c.table_opts.filter_policy) if(c.table_opts.filter_policy)
{ {
const auto k(slice(key)); const auto k(slice(key));
@ -8001,6 +8005,7 @@ ircd::db::has(column &column,
if(!d.d->KeyMayExist(opts, c, k, &discard, nullptr)) if(!d.d->KeyMayExist(opts, c, k, &discard, nullptr))
return false; return false;
} }
*/
const auto it const auto it
{ {