From 18634c122bf5e64c58ab791d892ebcb4b981779b Mon Sep 17 00:00:00 2001
From: Jason Volk <jason@zemos.net>
Date: Sat, 5 May 2018 03:22:20 -0700
Subject: [PATCH] modules/federation/federation: Improve version; move ostream
 to modules/console.

---
 modules/console.cc               | 25 ++++++++++++++++--
 modules/federation/federation.cc | 44 +++++++++++++++++++++++---------
 2 files changed, 55 insertions(+), 14 deletions(-)

diff --git a/modules/console.cc b/modules/console.cc
index 3b1a21e82..5388e3f2a 100644
--- a/modules/console.cc
+++ b/modules/console.cc
@@ -3532,15 +3532,36 @@ console_cmd__feds__version(opt &out, const string_view &line)
 		m::room_id(param.at(0))
 	};
 
+	using closure_prototype = bool (const string_view &,
+	                                std::exception_ptr,
+	                                const json::object &);
+
 	using prototype = void (const m::room::id &,
-	                        std::ostream &);
+	                        const milliseconds &,
+	                        const std::function<closure_prototype> &);
 
 	static m::import<prototype> feds__version
 	{
 		"federation_federation", "feds__version"
 	};
 
-	feds__version(room_id, out);
+	feds__version(room_id, out.timeout, [&out]
+	(const string_view &origin, std::exception_ptr eptr, const json::object &response)
+	{
+		out << (eptr? '-' : '+')
+		    << " "
+		    << std::setw(40) << std::left << origin
+		    << " ";
+
+		if(eptr)
+			out << what(eptr);
+		else
+			out << string_view{response};
+
+		out << std::endl;
+		return true;
+	});
+
 	return true;
 }
 
diff --git a/modules/federation/federation.cc b/modules/federation/federation.cc
index 23e165ed0..e8a29e611 100644
--- a/modules/federation/federation.cc
+++ b/modules/federation/federation.cc
@@ -24,6 +24,8 @@ namespace ircd::m::feds
 struct ircd::m::feds::version
 :m::v1::version
 {
+	using closure = std::function<bool (const string_view &, std::exception_ptr, const json::object &)>;
+
 	char origin[256];
 	char buf[16_KiB];
 
@@ -37,8 +39,8 @@ struct ircd::m::feds::version
 	}()}
 	{}
 
+	version(version &&) = delete;
 	version(const version &) = delete;
-	version &operator=(const version &) = delete;
 };
 
 std::list<m::feds::version>
@@ -67,31 +69,49 @@ feds__version(const m::room::id &room_id)
 }
 
 extern "C" void
-feds__version(const m::room::id &room_id, std::ostream &out)
+feds__version(const m::room::id &room_id,
+              const milliseconds &timeout,
+              const m::feds::version::closure &closure)
 {
 	auto reqs
 	{
 		feds__version(room_id)
 	};
 
-	auto all
+	auto when
 	{
-		ctx::when_all(begin(reqs), end(reqs))
+		now<steady_point>() + timeout
 	};
 
-	all.wait(30s, std::nothrow);
-
-	for(auto &req : reqs) try
+	while(!reqs.empty())
 	{
-		if(req.wait(1ms, std::nothrow))
+		auto next
+		{
+			ctx::when_any(begin(reqs), end(reqs))
+		};
+
+		if(!next.wait_until(when, std::nothrow))
+			break;
+
+		const auto it
+		{
+			next.get()
+		};
+
+		auto &req{*it}; try
 		{
 			const auto code{req.get()};
 			const json::object &response{req};
-			out << "+ " << std::setw(40) << std::left << req.origin
-			    << " " << string_view{response}
-			    << std::endl;
+			if(!closure(req.origin, {}, response))
+				break;
 		}
-		else cancel(req);
+		catch(const std::exception &)
+		{
+			if(!closure(req.origin, std::current_exception(), {}))
+				break;
+		}
+
+		reqs.erase(it);
 	}
 	catch(const std::exception &e)
 	{