MirrorHub/construct
0
0
Fork 0
mirror of https://github.com/matrix-construct/construct synced 2024-06-02 18:18:56 +02:00
Code Issues Releases Wiki Activity

ircd::http: Optimize head constructions; reduce branch paths.

Browse source
This commit is contained in:
Jason Volk 2020-03-13 11:07:39 -07:00
parent 33f1ce6e09
commit 2cefc5e248
2 changed files with 33 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
include/ircd/http.h
View file

@ -284,7 +284,8 @@ struct ircd::http::response::head
string_view headers;
head(parse::capstan &pc, const headers::closure &c = {});
head(parse::capstan &pc, const headers::closure &c);
head(parse::capstan &pc);
head() = default;
};

42
ircd/http.cc
View file

@ -289,7 +289,7 @@ namespace ircd::http
}
ircd::http::request::head::head(parse::capstan &pc,
const headers::closure &c)
const headers::closure &closure)
:line::request{pc}
,uri
{
@ -297,7 +297,7 @@ ircd::http::request::head::head(parse::capstan &pc,
query? string_view { begin(path), end(query) }:
string_view { begin(path), end(path) }
}
,headers{[this, &pc, &c]
,headers{[this, &pc, &closure]
{
const bool version_compatible
{
@ -315,14 +315,21 @@ ircd::http::request::head::head(parse::capstan &pc,
}
};
if(closure)
return http::headers
{
pc, [this, &closure](const auto &header)
{
assign(*this, header);
closure(header);
}
};
return http::headers
{
pc, [this, &c](const auto &header)
pc, [this](const auto &header)
{
assign(*this, header);
if(c)
c(header);
}
};
}()}
@ -508,19 +515,32 @@ namespace ircd::http
static void assign(response::head &, const header &);
}
ircd::http::response::head::head(parse::capstan &pc,
const headers::closure &c)
ircd::http::response::head::head(parse::capstan &pc)
:line::response{pc}
,headers
{
http::headers
{
pc, [this, &c](const auto &header)
pc, [this](const auto &header)
{
assign(*this, header);
}
}
}
{
}
if(c)
c(header);
ircd::http::response::head::head(parse::capstan &pc,
const headers::closure &closure)
:line::response{pc}
,headers
{
http::headers
{
pc, [this, &closure](const auto &header)
{
assign(*this, header);
closure(header);
}
}
}