MirrorHub/construct
0
0
Fork 0
mirror of https://github.com/matrix-construct/construct synced 2024-06-10 05:58:56 +02:00
Code Issues Releases Wiki Activity

ircd::db: Fix erroneous false hits from db::cached().

Browse source
This commit is contained in:
Jason Volk 2020-12-23 23:25:48 -08:00
parent 9523e3ca0a
commit 3b90a4a5a9
1 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
ircd/db.cc
View file

@ -3168,14 +3168,23 @@ ircd::db::cached(column &column,
auto opts(make_opts(gopts));
opts.read_tier = NON_BLOCKING;
opts.fill_cache = false;
const auto status
std::unique_ptr<rocksdb::Iterator> it;
database::column &c(column);
const bool valid
{
_read(column, key, opts)
seek(c, key, opts, it)
};
assert(it);
const auto code
{
it->status().code()
};
return false
|| status.code() == Status::kOk
|| status.code() == Status::kNotFound
|| (valid && valid_eq(*it, key))
|| (!valid && code != rocksdb::Status::kIncomplete)
;
}