From 3d380d09a3fbfd7b33982010c3cda56b1bca76e7 Mon Sep 17 00:00:00 2001
From: Jason Volk <jason@zemos.net>
Date: Thu, 25 Feb 2021 14:33:52 -0800
Subject: [PATCH] ircd::m: Fix various const reference range construction
 warnings in clang.

---
 matrix/keys.cc                           | 6 +++---
 matrix/rooms_summary.cc                  | 4 ++--
 matrix/user_pushrules.cc                 | 8 ++++----
 modules/client/delete_devices.cc         | 2 +-
 modules/federation/get_missing_events.cc | 2 +-
 5 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/matrix/keys.cc b/matrix/keys.cc
index fd31bd205..ffa28d137 100644
--- a/matrix/keys.cc
+++ b/matrix/keys.cc
@@ -236,7 +236,7 @@ try
 	};
 
 	bool ret(false);
-	for(const json::object &key : response) try
+	for(const json::object key : response) try
 	{
 		verify(m::keys{key});
 		if(!closure(key))
@@ -357,7 +357,7 @@ try
 		request
 	};
 
-	for(const json::object &keys : response)
+	for(const json::object keys : response)
 	{
 		if(unquote(keys["server_name"]) != server_name)
 			continue;
@@ -464,7 +464,7 @@ ircd::m::keys::get(const queries &queries,
 			result.object["server_keys"]
 		};
 
-		for(const json::object &keys : server_keys)
+		for(const json::object keys : server_keys)
 		{
 			const json::string &server_name
 			{
diff --git a/matrix/rooms_summary.cc b/matrix/rooms_summary.cc
index 442a5cb14..b3edde302 100644
--- a/matrix/rooms_summary.cc
+++ b/matrix/rooms_summary.cc
@@ -101,7 +101,7 @@ ircd::m::rooms::summary::fetch::fetch(const string_view &origin,
 		response.get("chunk")
 	};
 
-	for(const json::object &summary : chunk)
+	for(const json::object summary : chunk)
 	{
 		const json::string &room_id
 		{
@@ -401,7 +401,7 @@ ircd::m::rooms::summary::chunk_local(const m::room &room,
 				content["aliases"]
 			};
 
-			for(const json::string &a : aliases)
+			for(const json::string a : aliases)
 				array.append(a);
 		});
 	}
diff --git a/matrix/user_pushrules.cc b/matrix/user_pushrules.cc
index e915bc45f..ce8e97cea 100644
--- a/matrix/user_pushrules.cc
+++ b/matrix/user_pushrules.cc
@@ -153,9 +153,9 @@ const
 			push::rules::defaults.get<json::array>(kind)
 		};
 
-		for(const json::object &rule : rules)
+		for(const json::object rule : rules)
 		{
-			const json::string &_ruleid
+			const json::string _ruleid
 			{
 				rule["rule_id"]
 			};
@@ -214,9 +214,9 @@ const
 			if(kind && kind != _kind)
 				continue;
 
-			for(const json::object &rule : push::rules::defaults.at<json::array>(_kind))
+			for(const json::object rule : push::rules::defaults.at<json::array>(_kind))
 			{
-				const json::string &_ruleid
+				const json::string _ruleid
 				{
 					rule["rule_id"]
 				};
diff --git a/modules/client/delete_devices.cc b/modules/client/delete_devices.cc
index 922605bbc..a48dd206b 100644
--- a/modules/client/delete_devices.cc
+++ b/modules/client/delete_devices.cc
@@ -92,7 +92,7 @@ post__delete_devices(client &client,
 		request.user_id
 	};
 
-	for(const json::string &device_id : devices)
+	for(const json::string device_id : devices)
 		user_devices.del(device_id);
 
 	return m::resource::response
diff --git a/modules/federation/get_missing_events.cc b/modules/federation/get_missing_events.cc
index b08f335e4..133d7509b 100644
--- a/modules/federation/get_missing_events.cc
+++ b/modules/federation/get_missing_events.cc
@@ -158,7 +158,7 @@ get__missing_events(client &client,
 		return true;
 	}};
 
-	for(const json::string &event_id : latest)
+	for(const json::string event_id : latest)
 		add_queue(event_id);
 
 	m::event::fetch event;