modules/federation: Explicit path parameter checking for clearer error msgs.

modules/federation/backfill.cc

@@ -67,6 +67,12 @@ resource::response
 get__backfill(client &client,
               const resource::request &request)
 {
+	if(request.parv.size() < 1)
+		throw m::NEED_MORE_PARAMS
+		{
+			"room_id path parameter required"
+		};
+
 	m::room::id::buf room_id
 	{
 		url::decode(room_id, request.parv[0])

modules/federation/backfill_ids.cc

@@ -63,6 +63,12 @@ resource::response
 get__backfill_ids(client &client,
                   const resource::request &request)
 {
+	if(request.parv.size() < 1)
+		throw m::NEED_MORE_PARAMS
+		{
+			"room_id path parameter required"
+		};
+
 	m::room::id::buf room_id
 	{
 		url::decode(room_id, request.parv[0])

modules/federation/event.cc

@@ -33,6 +33,12 @@ resource::response
 handle_get(client &client,
            const resource::request &request)
 {
+	if(request.parv.size() < 1)
+		throw m::NEED_MORE_PARAMS
+		{
+			"event_id path parameter required."
+		};
+
 	m::event::id::buf event_id
 	{
 		url::decode(event_id, request.parv[0])

modules/federation/send.cc

@@ -93,6 +93,12 @@ resource::response
 handle_put(client &client,
            const resource::request::object<m::txn> &request)
 {
+	if(request.parv.size() < 1)
+		throw m::NEED_MORE_PARAMS
+		{
+			"txn_id path parameter required"
+		};
+
 	const auto txn_id
 	{
 		request.parv[0]

modules/federation/state.cc

@@ -37,6 +37,12 @@ resource::response
 get__state(client &client,
            const resource::request &request)
 {
+	if(request.parv.size() < 1)
+		throw m::NEED_MORE_PARAMS
+		{
+			"room_id path parameter required"
+		};
+
 	m::room::id::buf room_id
 	{
 		url::decode(room_id, request.parv[0])

modules/federation/state_ids.cc

@@ -30,6 +30,12 @@ resource::response
 get__state_ids(client &client,
                const resource::request &request)
 {
+	if(request.parv.size() < 1)
+		throw m::NEED_MORE_PARAMS
+		{
+			"room_id path parameter required"
+		};
+
 	m::room::id::buf room_id
 	{
 		url::decode(room_id, request.parv[0])

modules/federation/user_devices.cc

@@ -51,7 +51,7 @@ get__user_devices(client &client,
 
 	m::user::id::buf user_id
 	{
-		url::decode(user_id, request.parv[1])
+		url::decode(user_id, request.parv[0])
 	};
 
 	return resource::response