From 4ebc9fefaf2cd2bdafd3abf8148fb9a67e3ccb31 Mon Sep 17 00:00:00 2001 From: Jason Volk Date: Sun, 23 Apr 2023 13:19:16 -0700 Subject: [PATCH] modules/client/rooms/relations: Condition path param decode on non-empty args. --- modules/client/rooms/relations.cc | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/modules/client/rooms/relations.cc b/modules/client/rooms/relations.cc index 122acbb74..65e3cff2a 100644 --- a/modules/client/rooms/relations.cc +++ b/modules/client/rooms/relations.cc @@ -60,9 +60,11 @@ get__relations(client &client, "relation rel_type path parameter required" }; - const string_view &rel_type + const string_view rel_type { - url::decode(rel_type_buf, request.parv[3]) + request.parv.size() > 3? + url::decode(rel_type_buf, request.parv[3]): + string_view{} }; // Get the alleged type path parameter. @@ -75,9 +77,11 @@ get__relations(client &client, "relation ?type? path parameter required" }; - const string_view &type + const string_view type { - url::decode(type_buf, request.parv[4]) + request.parv.size() > 4? + url::decode(type_buf, request.parv[4]): + string_view{} }; const auto event_idx