ircd: Various quietudes.

include/ircd/asio.h

@@ -26,6 +26,8 @@
 
 #define BOOST_COROUTINES_NO_DEPRECATION_WARNING
 
+#include <boost/version.hpp>
+#include <boost/config.hpp>
 #include <boost/asio.hpp>
 #include <boost/asio/ssl.hpp>
 #include <boost/asio/steady_timer.hpp>

include/ircd/http.h

@@ -52,7 +52,7 @@ struct ircd::http::error
 	error() = default;
 	error(const http::code &, std::string content = {}, std::string headers = {});
 	error(const http::code &, std::string content, const vector_view<const header> &);
-	template<class... args> error(const http::code &, const string_view &fmt, args&&...);
+	template<size_t BUFSIZE, class... args> error(const http::code &, const string_view &fmt, args&&...);
 };
 
 /// Represents a single \r\n delimited line used in HTTP.
@@ -353,7 +353,8 @@ const
 	return lex_cast<T>(at(key));
 }
 
-template<class... args>
+template<size_t BUFSIZE,
+         class... args>
 ircd::http::error::error(const http::code &code,
                          const string_view &fmt,
                          args&&... a)

ircd/db.cc

@@ -4034,7 +4034,10 @@ ircd::db::txn::append::append(txn &t,
 ircd::db::txn::append::append(txn &t,
                               const row::delta &delta)
 {
-	assert(0);
+	throw ircd::not_implemented
+	{
+		"db::txn::append (row::delta)"
+	};
 }
 
 ircd::db::txn::append::append(txn &t,
@@ -6522,14 +6525,18 @@ ircd::db::error::error(generate_skip_t,
 //
 
 std::string
+__attribute__((noreturn))
 ircd::db::merge_operator(const string_view &key,
                          const std::pair<string_view, string_view> &delta)
 {
 	//ircd::json::index index{delta.first};
 	//index += delta.second;
 	//return index;
-	assert(0);
-	return {};
+
+	throw ircd::not_implemented
+	{
+		"db::merge_operator()"
+	};
 }
 
 ///////////////////////////////////////////////////////////////////////////////

ircd/db_env.cc

@@ -167,6 +167,7 @@ catch(const std::exception &e)
 }
 
 rocksdb::Status
+__attribute__((unused))
 ircd::db::database::env::ReuseWritableFile(const std::string &name,
                                            const std::string &old_name,
                                            std::unique_ptr<WritableFile> *const r,
@@ -186,7 +187,14 @@ noexcept try
 	};
 	#endif
 
-	assert(0);
+	throw ircd::not_implemented
+	{
+		"'%s': ReuseWritableFile(name:'%s' old:'%s')",
+		d.name,
+		name,
+		old_name
+	};
+
 	return Status::OK();
 	//return defaults.ReuseWritableFile(name, old_name, r, options);
 }
@@ -866,7 +874,7 @@ catch(const std::exception &e)
 void
 ircd::db::database::env::StartThread(void (*f)(void*),
                                      void *const a)
-noexcept
+noexcept try
 {
 	const ctx::uninterruptible::nothrow ui;
 
@@ -880,11 +888,20 @@ noexcept
 	};
 	#endif
 
-	throw panic
+	throw ircd::not_implemented
 	{
 		"Independent (non-pool) context spawning not yet implemented"
 	};
 }
+catch(const std::exception &e)
+{
+	log::critical
+	{
+		log, "'%s': start thread :%s",
+		d.name,
+		e.what()
+	};
+}
 
 void
 ircd::db::database::env::WaitForJoin()
@@ -1080,7 +1097,11 @@ noexcept try
 	};
 	#endif
 
-	assert(0);
+	throw ircd::not_implemented
+	{
+		"'%s': GetThreadList()", d.name
+	};
+
 	return defaults.GetThreadList(list);
 }
 catch(const std::exception &e)

ircd/ios.cc

@@ -8,7 +8,6 @@
 // copyright notice and this permission notice is present in all copies. The
 // full license for this software is available in the LICENSE file.
 
-#include <boost/version.hpp>
 #include <ircd/asio.h>
 
 /// Boost version indicator for compiled header files.