MirrorHub/construct
0
0
Fork 0
mirror of https://github.com/matrix-construct/construct synced 2024-12-11 08:02:59 +01:00
Code Issues Releases Wiki Activity

UID/EUID: Check that the UID starts with the server's SID.

Browse source 
If not, the local link that sent the command is broken, as with
syntactically invalid UIDs.
This commit is contained in:
Jilles Tjoelker 2013-02-03 19:38:46 +01:00
parent 9cbf72447c
commit 561d7efc44
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
modules/core/m_nick.c
View file

@ -94,7 +94,7 @@ static int change_remote_nick(struct Client *, struct Client *, time_t,
static int clean_nick(const char *, int loc_client); static int clean_nick(const char *, int loc_client);
static int clean_username(const char *); static int clean_username(const char *);
static int clean_host(const char *); static int clean_host(const char *);
static int clean_uid(const char *uid); static int clean_uid(const char *uid, const char *sid);
static void set_initial_nick(struct Client *client_p, struct Client *source_p, char *nick); static void set_initial_nick(struct Client *client_p, struct Client *source_p, char *nick);
static void change_local_nick(struct Client *client_p, struct Client *source_p, char *nick, int); static void change_local_nick(struct Client *client_p, struct Client *source_p, char *nick, int);
@ -362,7 +362,7 @@ ms_uid(struct Client *client_p, struct Client *source_p, int parc, const char *p
return 0; return 0;
} }
if(!clean_uid(parv[8])) if(!clean_uid(parv[8], source_p->id))
{ {
rb_snprintf(squitreason, sizeof squitreason, rb_snprintf(squitreason, sizeof squitreason,
"Invalid UID %s for nick %s on %s", "Invalid UID %s for nick %s on %s",
@ -453,7 +453,7 @@ ms_euid(struct Client *client_p, struct Client *source_p, int parc, const char *
return 0; return 0;
} }
if(!clean_uid(parv[8])) if(!clean_uid(parv[8], source_p->id))
{ {
rb_snprintf(squitreason, sizeof squitreason, rb_snprintf(squitreason, sizeof squitreason,
"Invalid UID %s for nick %s on %s", "Invalid UID %s for nick %s on %s",
@ -623,10 +623,13 @@ clean_host(const char *host)
} }
static int static int
clean_uid(const char *uid) clean_uid(const char *uid, const char *sid)
{ {
int len = 1; int len = 1;
if(strncmp(uid, sid, strlen(sid)))
return 0;
if(!IsDigit(*uid++)) if(!IsDigit(*uid++))
return 0; return 0;