MirrorHub/construct
0
0
Fork 0
mirror of https://github.com/matrix-construct/construct synced 2024-05-19 19:33:45 +02:00
Code Issues Releases Wiki Activity

ircd::db: Optimize iterator comparison operators.

Browse source
This commit is contained in:
Jason Volk 2020-09-21 18:48:08 -07:00
parent 2741ab785c
commit 7201a11c7a
1 changed files with 25 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
ircd/db.cc
View file

@ -7407,24 +7407,43 @@ bool
ircd::db::operator!=(const column::const_iterator_base &a, const column::const_iterator_base &b)
noexcept
{
return !(a == b);
const uint operands
{
uint(bool(a)) +
uint(bool(b))
};
// Two invalid iterators are equal; one invalid iterator is not.
if(likely(operands <= 1))
return operands == 1;
// Two valid iterators are compared
assert(operands == 2);
const auto &ak(a.it->key());
const auto &bk(b.it->key());
return ak.compare(bk) != 0;
}
bool
ircd::db::operator==(const column::const_iterator_base &a, const column::const_iterator_base &b)
noexcept
{
if(a && b)
const uint operands
{
uint(bool(a)) +
uint(bool(b))
};
// Two valid iterators are compared
if(likely(operands > 1))
{
const auto &ak(a.it->key());
const auto &bk(b.it->key());
return ak.compare(bk) == 0;
}
if(!a && !b)
return true;
return false;
// Two invalid iterators are equal; one invalid iterator is not.
return operands == 0;
}
bool