MirrorHub/construct
0
0
Fork 0
mirror of https://github.com/matrix-construct/construct synced 2025-01-14 16:46:50 +01:00
Code Issues Releases Wiki Activity

ircd::fs: Add slice usage warning reasons; simplify conditional logic.

Browse source
This commit is contained in:
Jason Volk 2018-12-17 16:02:05 -08:00
parent a7b2f76c11
commit 81ca6fecf4
1 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
ircd/fs.cc
View file

@ -503,6 +503,11 @@ void
ircd::fs::sync(const fd &fd, ircd::fs::sync(const fd &fd,
const sync_opts &opts) const sync_opts &opts)
{ {
const ctx::slice_usage_warning message
{
"fs::sync(fd:%d)", int(fd)
};
#ifdef __linux__ #ifdef __linux__
syscall(::syncfs, fd); syscall(::syncfs, fd);
#else #else
@ -523,13 +528,22 @@ void
ircd::fs::flush(const fd &fd, ircd::fs::flush(const fd &fd,
const sync_opts &opts) const sync_opts &opts)
{ {
const ctx::slice_usage_warning message
{
"fs::flush(fd:%d, {metadata:%b aio:%b:%b})",
int(fd),
opts.metadata,
opts.aio,
opts.metadata? support::aio_fdsync : support::aio_fsync
};
#ifdef IRCD_USE_AIO #ifdef IRCD_USE_AIO
if(aio::context && opts.aio) if(aio::context && opts.aio)
{ {
if(!opts.metadata && support::aio_fdsync) if(!opts.metadata && support::aio_fdsync)
return aio::fdsync(fd, opts); return aio::fdsync(fd, opts);
if(opts.metadata && support::aio_fsync) if(support::aio_fsync)
return aio::fsync(fd, opts); return aio::fsync(fd, opts);
} }
#endif #endif
@ -537,7 +551,6 @@ ircd::fs::flush(const fd &fd,
if(!opts.metadata) if(!opts.metadata)
return void(syscall(::fdatasync, fd)); return void(syscall(::fdatasync, fd));
if(opts.metadata)
return void(syscall(::fsync, fd)); return void(syscall(::fsync, fd));
} }