MirrorHub/construct
0
0
Fork 0
mirror of https://github.com/matrix-construct/construct synced 2024-11-17 23:40:57 +01:00
Code Issues Releases Wiki Activity

modules/client/sync/rooms/timeline: Add exposure depth condition to not sync irrelevant events.

Browse source
This commit is contained in:
Jason Volk 2019-06-05 16:57:27 -07:00
parent 359ab6e897
commit a99a7e2501
1 changed files with 39 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
modules/client/sync/rooms/timeline.cc
View file

@ -23,6 +23,8 @@ namespace ircd::m::sync
static bool _room_timeline_linear_command(data &); static bool _room_timeline_linear_command(data &);
static bool room_timeline_linear(data &); static bool room_timeline_linear(data &);
extern const string_view exposure_depth_description;
extern conf::item<int64_t> exposure_depth;
extern conf::item<size_t> limit_default; extern conf::item<size_t> limit_default;
extern const event::keys::include default_keys; extern const event::keys::include default_keys;
extern item room_timeline; extern item room_timeline;
@ -58,6 +60,23 @@ ircd::m::sync::limit_default
{ "default", 10L }, { "default", 10L },
}; };
decltype(ircd::m::sync::exposure_depth)
ircd::m::sync::exposure_depth
{
{ "name", "ircd.client.sync.rooms.timeline.exposure.depth" },
{ "default", 20L },
{ "description", exposure_depth_description },
};
decltype(ircd::m::sync::exposure_depth_description)
ircd::m::sync::exposure_depth_description
{R"(
Does not linear-sync timeline events whose distance from the room head
is greater than this value. This prevents past events from appearing at
the bottom of the timeline in clients which do not sort their timeline to
prevent an incoherent conversation when the server obtains past events.
)"};
bool bool
ircd::m::sync::room_timeline_linear(data &data) ircd::m::sync::room_timeline_linear(data &data)
{ {
@ -70,11 +89,6 @@ ircd::m::sync::room_timeline_linear(data &data)
if(!data.membership && *data.room != data.user_room) if(!data.membership && *data.room != data.user_room)
return false; return false;
json::stack::object rooms
{
*data.out, "rooms"
};
assert(data.event); assert(data.event);
const bool command const bool command
{ {
@ -84,9 +98,29 @@ ircd::m::sync::room_timeline_linear(data &data)
json::get<"sender"_>(*data.event) == data.user.user_id) json::get<"sender"_>(*data.event) == data.user.user_id)
}; };
json::stack::object rooms
{
*data.out, "rooms"
};
if(command) if(command)
return _room_timeline_linear_command(data); return _room_timeline_linear_command(data);
if(int64_t(exposure_depth) > -1)
{
const bool belated
{
// Don't apply this condition to state events for now
!defined(json::get<"state_key"_>(*data.event)) &&
// Check if the depth is too far in the past relative to the room head
json::get<"depth"_>(*data.event) + int64_t(exposure_depth) < data.room_depth
};
if(belated)
return false;
}
json::stack::object membership_ json::stack::object membership_
{ {
*data.out, data.membership *data.out, data.membership