MirrorHub/construct
0
0
Fork 0
mirror of https://github.com/matrix-construct/construct synced 2024-06-02 18:18:56 +02:00
Code Issues Releases Wiki Activity

ircd::ctx: Patch issues with direct jump.

Browse source
This commit is contained in:
Jason Volk 2017-08-18 16:54:34 -06:00
parent 9f12672567
commit b6d51b89dd
1 changed files with 18 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
ircd/ctx.cc
View file

@ -138,18 +138,17 @@ ircd::ctx::ctx::jump()
auto &yc(*this->yc);
auto &target(*yc.coro_.lock());
{
// Notes must be cleared before the continuation{}
notes = 0;
// Jump from the currently running context (source) to *this (target)
// with continuation of source after target
// Jump from the currently running context (source) to *this (target)
// with continuation of source after target
{
current->notes = 0; // Unconditionally cleared here
const continuation continuation{current};
target();
}
assert(current != this);
assert(notes == 1); // notes = 1; set by continuation dtor on wakeup
assert(current->notes == 1); // notes = 1; set by continuation dtor on wakeup
interruption_point();
}
@ -286,7 +285,19 @@ void
ircd::ctx::yield(ctx &ctx)
{
assert(current);
ctx.jump();
//ctx.jump();
// !!! TODO !!!
// XXX: We can't jump directly to a context if it's waiting on its alarm, and
// we don't know whether it's waiting on its alarm. We can add another flag to
// inform us of that, but most contexts are usually waiting on their alarm anyway.
//
// Perhaps a better way to do this would be to centralize the alarms into a single
// context with the sole job of waiting on a single alarm. Then it can schedule
// things allowing for more direct jumps until all work is complete.
// !!! TODO !!!
notify(ctx);
}
void