From b9cf0c979633680baef9a84c1669be664b134d79 Mon Sep 17 00:00:00 2001
From: Jason Volk <jason@zemos.net>
Date: Sat, 14 Apr 2018 17:14:31 -0700
Subject: [PATCH] ircd::rfc1035: Comparison operator suite for record types.

---
 include/ircd/rfc1035.h | 12 +++++++++
 ircd/rfc1035.cc        | 59 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 71 insertions(+)

diff --git a/include/ircd/rfc1035.h b/include/ircd/rfc1035.h
index 1908f3864..ddd12ec0f 100644
--- a/include/ircd/rfc1035.h
+++ b/include/ircd/rfc1035.h
@@ -184,6 +184,9 @@ struct ircd::rfc1035::record::A
 
 	A(const answer &);
 	A();
+
+	friend bool operator==(const A &, const A &);
+	friend bool operator!=(const A &, const A &);
 };
 
 /// IPv6 address record.
@@ -195,6 +198,9 @@ struct ircd::rfc1035::record::AAAA
 
 	AAAA(const answer &);
 	AAAA();
+
+	friend bool operator==(const AAAA &, const AAAA &);
+	friend bool operator!=(const AAAA &, const AAAA &);
 };
 
 /// Canonical name aliasing record
@@ -206,6 +212,9 @@ struct ircd::rfc1035::record::CNAME
 
 	CNAME(const answer &);
 	CNAME();
+
+	friend bool operator==(const CNAME &, const CNAME &);
+	friend bool operator!=(const CNAME &, const CNAME &);
 };
 
 /// Service record.
@@ -221,4 +230,7 @@ struct ircd::rfc1035::record::SRV
 
 	SRV(const answer &);
 	SRV();
+
+	friend bool operator==(const SRV &, const SRV &);
+	friend bool operator!=(const SRV &, const SRV &);
 };
diff --git a/ircd/rfc1035.cc b/ircd/rfc1035.cc
index 855d2eac8..f5235d788 100644
--- a/ircd/rfc1035.cc
+++ b/ircd/rfc1035.cc
@@ -218,6 +218,18 @@ ircd::rfc1035::record::A::A(const answer &answer)
 	ip4 = bswap(*(const uint32_t *)data(rdata));
 }
 
+bool
+ircd::rfc1035::operator!=(const record::A &a, const record::A &b)
+{
+	return !(a == b);
+}
+
+bool
+ircd::rfc1035::operator==(const record::A &a, const record::A &b)
+{
+	return a.ip4 == b.ip4;
+}
+
 //
 // AAAA
 //
@@ -240,6 +252,22 @@ ircd::rfc1035::record::AAAA::AAAA(const answer &answer)
 	ip6 = bswap(*(const uint128_t *)data(rdata));
 }
 
+bool
+ircd::rfc1035::operator!=(const record::AAAA &a, const record::AAAA &b)
+{
+	return !(a == b);
+}
+
+bool
+ircd::rfc1035::operator==(const record::AAAA &a, const record::AAAA &b)
+{
+	return a.ip6 == b.ip6;
+}
+
+//
+// CNAME
+//
+
 ircd::rfc1035::record::CNAME::CNAME()
 :record{5}
 {
@@ -258,6 +286,22 @@ ircd::rfc1035::record::CNAME::CNAME(const answer &answer)
 	name = string_view{namebuf, len - 1};
 }
 
+bool
+ircd::rfc1035::operator!=(const record::CNAME &a, const record::CNAME &b)
+{
+	return !(a == b);
+}
+
+bool
+ircd::rfc1035::operator==(const record::CNAME &a, const record::CNAME &b)
+{
+	return a.name == b.name;
+}
+
+//
+// SRV
+//
+
 ircd::rfc1035::record::SRV::SRV()
 :record{33}
 {
@@ -285,6 +329,21 @@ ircd::rfc1035::record::SRV::SRV(const answer &answer)
 	assert(std::distance(pos, end(rdata)) == 0);
 }
 
+bool
+ircd::rfc1035::operator!=(const record::SRV &a, const record::SRV &b)
+{
+	return !(a == b);
+}
+
+bool
+ircd::rfc1035::operator==(const record::SRV &a, const record::SRV &b)
+{
+	return a.tgt == b.tgt &&
+	       a.port == b.port &&
+	       a.weight == b.weight &&
+	       a.priority == b.priority;
+}
+
 //
 // Util / misc
 //