MirrorHub/construct
0
0
Fork 0
mirror of https://github.com/matrix-construct/construct synced 2025-01-13 08:23:56 +01:00
Code Issues Releases Wiki Activity

modules/s_dns: Replace magic numbers with proper qtypes.

Browse source
This commit is contained in:
Jason Volk 2018-11-13 23:19:57 -08:00
parent aedc4c73b1
commit c28e152954
1 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
modules/s_dns.cc
View file

@ -119,6 +119,10 @@ ircd::net::dns::handle__SRV(callback_SRV_one callback,
const records &rrs)
{
static const rfc1035::record::SRV empty;
static const auto &qtype
{
rfc1035::qtype.at("SRV")
};
if(eptr)
return callback(std::move(eptr), hp, empty);
@ -126,8 +130,8 @@ ircd::net::dns::handle__SRV(callback_SRV_one callback,
//TODO: prng on weight / prio plz
for(size_t i(0); i < rrs.size(); ++i)
{
const auto &rr{*rrs.at(i)};
if(rr.type != 33)
const auto &rr(*rrs.at(i));
if(rr.type != qtype)
continue;
const auto &record(rr.as<const rfc1035::record::SRV>());
@ -175,6 +179,10 @@ ircd::net::dns::handle__A(callback_A_one callback,
const records &rrs)
{
static const rfc1035::record::A empty;
static const auto &qtype
{
rfc1035::qtype.at("A")
};
if(eptr)
return callback(std::move(eptr), hp, empty);
@ -182,8 +190,8 @@ ircd::net::dns::handle__A(callback_A_one callback,
//TODO: prng plz
for(size_t i(0); i < rrs.size(); ++i)
{
const auto &rr{*rrs.at(i)};
if(rr.type != 1)
const auto &rr(*rrs.at(i));
if(rr.type != qtype)
continue;
const auto &record(rr.as<const rfc1035::record::A>());