From c5f4ab4a17dec52a0ce97bea07b2384ed112ad30 Mon Sep 17 00:00:00 2001
From: Jason Volk <jason@zemos.net>
Date: Mon, 19 Feb 2018 16:47:17 -0800
Subject: [PATCH] ircd::buffer: Compiler errors when copy source may be string
 literal.

---
 include/ircd/buffer.h | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/include/ircd/buffer.h b/include/ircd/buffer.h
index b952ef5b2..47c8d56df 100644
--- a/include/ircd/buffer.h
+++ b/include/ircd/buffer.h
@@ -63,6 +63,7 @@ namespace ircd::buffer
 	template<class it> size_t consume(buffer<it> &buffer, const size_t &bytes);
 	template<class it> buffer<it> operator+(const buffer<it> &buffer, const size_t &bytes);
 	template<class it> it copy(it &dest, const it &stop, const const_buffer &);
+	template<size_t SIZE> size_t copy(const mutable_buffer &dst, const char (&buf)[SIZE]);
 	size_t copy(const mutable_buffer &dst, const const_buffer &src);
 	size_t reverse(const mutable_buffer &dst, const const_buffer &src);
 	void reverse(const mutable_buffer &buf);
@@ -535,6 +536,19 @@ ircd::buffer::reverse(const mutable_buffer &dst,
 	return ret;
 }
 
+template<size_t SIZE>
+__attribute__((error
+(
+	"Copy source is an array. Is this a string literal? Do you want to copy the \\0?"
+	" Disambiguate this by typing the source string_view or const_buffer."
+)))
+inline size_t
+ircd::buffer::copy(const mutable_buffer &dst,
+                   const char (&buf)[SIZE])
+{
+	return copy(dst, const_buffer{buf});
+}
+
 inline size_t
 ircd::buffer::copy(const mutable_buffer &dst,
                    const const_buffer &src)