MirrorHub/construct
0
0
Fork 0
mirror of https://github.com/matrix-construct/construct synced 2024-11-18 07:50:57 +01:00
Code Issues Releases Wiki Activity

ircd::aio: Simplify stats.

Browse source
This commit is contained in:
Jason Volk 2018-12-28 16:30:27 -08:00
parent 4de73b5085
commit c93cd90db1
3 changed files with 0 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
include/ircd/fs/aio.h
View file

@ -42,16 +42,6 @@ namespace ircd::fs::aio
/// Statistics structure. /// Statistics structure.
/// ///
/// Subtract complete from requests to get the count of requests pending
/// "in flight." Subtract errors from complete to only get the count of
/// fully successful operations. complete will always eventually match
/// up with requests.
///
/// Subtract complete_bytes from requests_bytes to get the total bytes
/// currently pending "in flight." Subtract errors_bytes from response_bytes
/// to only get bytes successfully read or written. complete_bytes will
/// always eventually match up with requests_bytes.
///
struct ircd::fs::aio::stats struct ircd::fs::aio::stats
{ {
uint32_t requests {0}; ///< count of requests created uint32_t requests {0}; ///< count of requests created
@ -80,10 +70,6 @@ struct ircd::fs::aio::stats
uint32_t max_requests {0}; ///< maximum observed pending requests uint32_t max_requests {0}; ///< maximum observed pending requests
uint32_t max_reads {0}; ///< maximum observed pending reads uint32_t max_reads {0}; ///< maximum observed pending reads
uint32_t max_writes {0}; ///< maximum observed pending write uint32_t max_writes {0}; ///< maximum observed pending write
uint32_t maxed_submits {0}; ///< number of submits at threshold
uint32_t single_submits {0}; ///< number of submits of just one
uint32_t chased_submits {0}; ///< number of submits via chase
}; };
struct ircd::fs::aio::init struct ircd::fs::aio::init

5
ircd/aio.cc
View file

@ -588,10 +588,7 @@ ircd::fs::aio::system::chase()
noexcept noexcept
{ {
if(qcount) if(qcount)
{
flush(); flush();
stats.chased_submits++;
}
} }
/// The flusher submits all queued requests and resets the count. /// The flusher submits all queued requests and resets the count.
@ -605,8 +602,6 @@ noexcept try
syscall<SYS_io_submit>(idp, qcount, queue.data()); syscall<SYS_io_submit>(idp, qcount, queue.data());
stats.maxed_submits += qcount >= size_t(max_submit);
stats.single_submits += qcount == 1;
stats.cur_submits += qcount; stats.cur_submits += qcount;
stats.cur_queued -= qcount; stats.cur_queued -= qcount;
stats.submits++; stats.submits++;

12
modules/console.cc
View file

@ -907,18 +907,6 @@ console_cmd__aio(opt &out, const string_view &line)
<< std::setw(9) << std::right << s.submits << std::setw(9) << std::right << s.submits
<< std::endl; << std::endl;
out << std::setw(12) << std::left << "submits max"
<< std::setw(9) << std::right << s.maxed_submits
<< std::endl;
out << std::setw(12) << std::left << "submits one"
<< std::setw(9) << std::right << s.single_submits
<< std::endl;
out << std::setw(12) << std::left << "submits chs"
<< std::setw(9) << std::right << s.chased_submits
<< std::endl;
return true; return true;
} }