MirrorHub/construct
0
0
Fork 0
mirror of https://github.com/matrix-construct/construct synced 2024-11-17 23:40:57 +01:00
Code Issues Releases Wiki Activity

modules/client/rooms: Add pre-checks for membership on the convenience endpoints.

Browse source
This commit is contained in:
Jason Volk 2019-06-21 16:45:42 -07:00
parent b7023a6dc7
commit c944818f4b
3 changed files with 33 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
modules/client/rooms/ban.cc
View file

@ -40,6 +40,18 @@ post__ban(client &client,
power.level("ban")
};
// Check if the target user has any membership state at all. We don't
// yet care *what* that state is, and whatever that is may also change,
// but we can filter out clearly mistaken requests and typo'ed inputs.
if(!room.has("m.room.member", user_id))
throw m::error
{
http::NOT_MODIFIED, "M_TARGET_NOT_IN_ROOM",
"The user %s has no membership state in %s",
string_view{user_id},
string_view{room_id},
};
const auto event_id
{
send(room, request.user_id, "m.room.member", user_id,

12
modules/client/rooms/kick.cc
View file

@ -40,6 +40,18 @@ post__kick(client &client,
power.level("kick")
};
// Check if the target user has any membership state at all. We don't
// yet care *what* that state is, and whatever that is may also change,
// but we can filter out clearly mistaken requests and typo'ed inputs.
if(!room.has("m.room.member", user_id))
throw m::error
{
http::NOT_MODIFIED, "M_TARGET_NOT_IN_ROOM",
"The user %s has no membership state in %s",
string_view{user_id},
string_view{room_id},
};
const auto event_id
{
send(room, request.user_id, "m.room.member", user_id,

9
modules/client/rooms/leave.cc
View file

@ -23,6 +23,15 @@ post__leave(client &client,
room_id
};
if(!room.has("m.room.member", request.user_id))
throw m::error
{
http::NOT_MODIFIED, "M_TARGET_NOT_IN_ROOM",
"The user %s has no membership state in %s",
string_view{request.user_id},
string_view{room_id},
};
const auto event_id
{
m::leave(room, request.user_id)