MirrorHub/construct
0
0
Fork 0
mirror of https://github.com/matrix-construct/construct synced 2024-11-17 15:30:52 +01:00
Code Issues Releases Wiki Activity

ircd::db: Remove critical assertion here and add note.

Browse source
This commit is contained in:
Jason Volk 2018-11-29 16:18:29 -08:00
parent c74debac01
commit d1bfba2204
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ircd/db.cc
View file

@ -8419,7 +8419,6 @@ ircd::db::row::row(database &d,
// and reserve() it with one worst-case size of all possible columns. // and reserve() it with one worst-case size of all possible columns.
// Then we resize it to this specific call's requirements and copy the // Then we resize it to this specific call's requirements and copy the
// column pointers. On sane platforms only one allocation ever occurs. // column pointers. On sane platforms only one allocation ever occurs.
const ctx::critical_assertion ca;
thread_local std::vector<ColumnFamilyHandle *> handles; thread_local std::vector<ColumnFamilyHandle *> handles;
assert(column_count <= d.columns.size()); assert(column_count <= d.columns.size());
handles.reserve(d.columns.size()); handles.reserve(d.columns.size());
@ -8430,6 +8429,9 @@ ircd::db::row::row(database &d,
return ptr->handle.get(); return ptr->handle.get();
}); });
// This has been seen to lead to IO and block the ircd::ctx;
// specifically when background options are aggressive and shortly
// after db opens.
throw_on_error throw_on_error
{ {
d.d->NewIterators(options, handles, &iterators) d.d->NewIterators(options, handles, &iterators)