MirrorHub/construct
0
0
Fork 0
mirror of https://github.com/matrix-construct/construct synced 2025-01-14 00:34:18 +01:00
Code Issues Releases Wiki Activity

ircd:Ⓜ️ Optimize query for room::members::for_each w/ user_id closure.

Browse source
This commit is contained in:
Jason Volk 2018-05-20 20:16:31 -07:00
parent 67b7a58f42
commit db026147b7
1 changed files with 33 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
ircd/m/room.cc
View file

@ -1322,11 +1322,44 @@ const
}});
}
/// Iterate the mxid's of the users in the room, optionally with a specific
/// membership state. This query contains internal optimizations as the closure
/// only requires a user::id. The db::gopts set in the room.fopts pointer is
/// still used if provided.
bool
ircd::m::room::members::for_each(const string_view &membership,
const closure_bool &closure)
const
{
// Setup the list of event fields to fetch for the closure
static const event::keys keys
{
event::keys::include
{
"event_id",
"membership",
"state_key",
}
};
// In this case the fetch opts isn't static so it can maintain the
// previously given db::gopts, but it will use our keys list.
const m::event::fetch::opts fopts
{
keys, room.fopts? room.fopts->gopts : db::gopts{}
};
// Stack-over the the current fetch opts with our new opts for this query,
// putting them back when we're finished. This requires a const_cast which
// should be okay here.
auto &room(const_cast<m::room &>(this->room));
const auto theirs{room.fopts};
room.fopts = &fopts;
const unwind reset{[&room, &theirs]
{
room.fopts = theirs;
}};
return !test(membership, event::closure_bool{[&closure]
(const event &event)
{