From e1a9785abeccb4627b175b743085eb5641f6c3f6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mantas=20Mikul=C4=97nas?= Date: Wed, 11 Sep 2013 00:57:48 +0300 Subject: [PATCH] Remove CHARSET=ascii from ISUPPORT For one, [draft-brocklesby-irc-isupport-02][1] already defines "ascii" as the default value. According to section 2 ("Except as explicitly stated in its definition, a parameter should not be sent unless it changes this default value, or the default value is vague, badly defined, or differs between IRC server implementations"), there is no point in sending it. For another, [version 03 of the same draft][2] removes CHARSET ("It was found to be unworkable; a correct specification could not be devised to represent its meaning across implementations."), and the token is not present at all in [draft-hardy-irc-isupport-00][3]. [1]: https://tools.ietf.org/html/draft-brocklesby-irc-isupport-02#section-3.17 [2]: https://tools.ietf.org/html/draft-brocklesby-irc-isupport-03#section-4.8 [3]: https://tools.ietf.org/html/draft-hardy-irc-isupport-00 --- src/supported.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/supported.c b/src/supported.c index 8133d548c..420e07b12 100644 --- a/src/supported.c +++ b/src/supported.c @@ -329,7 +329,6 @@ init_isupport(void) add_isupport("STATUSMSG", isupport_string, "@+"); add_isupport("CALLERID", isupport_umode, "g"); add_isupport("CASEMAPPING", isupport_string, "rfc1459"); - add_isupport("CHARSET", isupport_string, "ascii"); add_isupport("NICKLEN", isupport_nicklen, NULL); add_isupport("MAXNICKLEN", isupport_intptr, &maxnicklen); add_isupport("CHANNELLEN", isupport_intptr, &channellen);