MirrorHub/construct
0
0
Fork 0
mirror of https://github.com/matrix-construct/construct synced 2024-12-26 15:33:54 +01:00
Code Issues Releases Wiki Activity

modules/stats: Fix unbuffered output generating too many chunks.

Browse source
This commit is contained in:
Jason Volk 2023-02-05 20:29:55 -08:00
parent 10de5ea52d
commit e6a77a80d6
1 changed files with 65 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

72
modules/stats.cc
View file

@ -10,6 +10,8 @@
namespace ircd::stats namespace ircd::stats
{ {
static const_buffer print_item(stats::item<void> &item, const mutable_buffer &, const time_t &);
static void each_item(resource::response::chunked &, stats::item<void> &, window_buffer &, const time_t &);
static resource::response get_stats(client &, const resource::request &); static resource::response get_stats(client &, const resource::request &);
extern resource::method method_get; extern resource::method method_get;
@ -46,32 +48,76 @@ ircd::stats::get_stats(client &client,
client, http::OK, "text/plain" client, http::OK, "text/plain"
}; };
window_buffer buf
{
response.buf
};
const time_t ts const time_t ts
{ {
ircd::time<milliseconds>() ircd::time<milliseconds>()
}; };
for(const auto &item : items) for(const auto &item : items)
each_item(response, *item, buf, ts);
const auto flushed
{ {
char buf[256], name[2][128], val[64]; response.flush(buf.completed())
const string_view _name
{
replace(name[0], item->name, '.', '_')
}; };
const string_view line buf.shift(size(flushed));
assert(!buf.consumed());
return response;
}
void
ircd::stats::each_item(resource::response::chunked &response,
stats::item<void> &item,
window_buffer &buf,
const time_t &ts)
{ {
buf, size_t(::snprintf buf([&item, &ts]
(const mutable_buffer &buf)
{
return print_item(item, buf, ts);
});
if(buf.remaining() >= 1_KiB)
return;
const auto completed
{
buf.completed()
};
const auto flushed
{
response.flush(completed)
};
buf.shift(size(flushed));
}
ircd::const_buffer
ircd::stats::print_item(stats::item<void> &item,
const mutable_buffer &buf,
const time_t &ts)
{
char name[2][128], val[64];
const string_view _name
{
replace(name[0], item.name, '.', '_')
};
return string_view
{
data(buf), size_t(::snprintf
( (
buf, sizeof(buf), "%s %s %lu\n", data(buf), size(buf), "%s %s %lu\n",
data(strlcpy(name[1], _name)), data(strlcpy(name[1], _name)),
data(string(val, *item)), data(string(val, item)),
ts ts
)) ))
}; };
response.write(line);
}
return response;
} }