mirror of
https://github.com/matrix-org/dendrite
synced 2024-06-26 16:28:19 +02:00
Add syncapi_memberships table tests (#2805)
This commit is contained in:
Till
GitHub
parent
9e4c3171da
commit
3cf42a1d64
198
syncapi/storage/tables/memberships_test.go
Normal file
198
syncapi/storage/tables/memberships_test.go
Normal file
|
|
@ -0,0 +1,198 @@
|
|||
package tables_test
|
||||
|
||||
import (
|
||||
"context"
|
||||
"database/sql"
|
||||
"reflect"
|
||||
"sort"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/matrix-org/gomatrixserverlib"
|
||||
|
||||
"github.com/matrix-org/dendrite/internal/sqlutil"
|
||||
"github.com/matrix-org/dendrite/setup/config"
|
||||
"github.com/matrix-org/dendrite/syncapi/storage/postgres"
|
||||
"github.com/matrix-org/dendrite/syncapi/storage/sqlite3"
|
||||
"github.com/matrix-org/dendrite/syncapi/storage/tables"
|
||||
"github.com/matrix-org/dendrite/syncapi/types"
|
||||
"github.com/matrix-org/dendrite/test"
|
||||
)
|
||||
|
||||
func newMembershipsTable(t *testing.T, dbType test.DBType) (tables.Memberships, *sql.DB, func()) {
|
||||
t.Helper()
|
||||
connStr, close := test.PrepareDBConnectionString(t, dbType)
|
||||
db, err := sqlutil.Open(&config.DatabaseOptions{
|
||||
ConnectionString: config.DataSource(connStr),
|
||||
}, sqlutil.NewExclusiveWriter())
|
||||
if err != nil {
|
||||
t.Fatalf("failed to open db: %s", err)
|
||||
}
|
||||
|
||||
var tab tables.Memberships
|
||||
switch dbType {
|
||||
case test.DBTypePostgres:
|
||||
tab, err = postgres.NewPostgresMembershipsTable(db)
|
||||
case test.DBTypeSQLite:
|
||||
tab, err = sqlite3.NewSqliteMembershipsTable(db)
|
||||
}
|
||||
if err != nil {
|
||||
t.Fatalf("failed to make new table: %s", err)
|
||||
}
|
||||
return tab, db, close
|
||||
}
|
||||
|
||||
func TestMembershipsTable(t *testing.T) {
|
||||
|
||||
alice := test.NewUser(t)
|
||||
room := test.NewRoom(t, alice)
|
||||
|
||||
// Create users
|
||||
var userEvents []*gomatrixserverlib.HeaderedEvent
|
||||
users := []string{alice.ID}
|
||||
for _, x := range room.CurrentState() {
|
||||
if x.StateKeyEquals(alice.ID) {
|
||||
if _, err := x.Membership(); err == nil {
|
||||
userEvents = append(userEvents, x)
|
||||
break
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if len(userEvents) == 0 {
|
||||
t.Fatalf("didn't find creator membership event")
|
||||
}
|
||||
|
||||
for i := 0; i < 10; i++ {
|
||||
u := test.NewUser(t)
|
||||
users = append(users, u.ID)
|
||||
|
||||
ev := room.CreateAndInsert(t, u, gomatrixserverlib.MRoomMember, map[string]interface{}{
|
||||
"membership": "join",
|
||||
}, test.WithStateKey(u.ID))
|
||||
userEvents = append(userEvents, ev)
|
||||
}
|
||||
|
||||
test.WithAllDatabases(t, func(t *testing.T, dbType test.DBType) {
|
||||
table, _, close := newMembershipsTable(t, dbType)
|
||||
defer close()
|
||||
|
||||
ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
|
||||
defer cancel()
|
||||
|
||||
for _, ev := range userEvents {
|
||||
if err := table.UpsertMembership(ctx, nil, ev, types.StreamPosition(ev.Depth()), 1); err != nil {
|
||||
t.Fatalf("failed to upsert membership: %s", err)
|
||||
}
|
||||
}
|
||||
|
||||
testUpsert(t, ctx, table, userEvents[0], alice, room)
|
||||
testMembershipCount(t, ctx, table, room)
|
||||
testHeroes(t, ctx, table, alice, room, users)
|
||||
})
|
||||
}
|
||||
|
||||
func testHeroes(t *testing.T, ctx context.Context, table tables.Memberships, user *test.User, room *test.Room, users []string) {
|
||||
|
||||
// Re-slice and sort the expected users
|
||||
users = users[1:]
|
||||
sort.Strings(users)
|
||||
type testCase struct {
|
||||
name string
|
||||
memberships []string
|
||||
wantHeroes []string
|
||||
}
|
||||
|
||||
testCases := []testCase{
|
||||
{name: "no memberships queried", memberships: []string{}},
|
||||
{name: "joined memberships queried should be limited", memberships: []string{gomatrixserverlib.Join}, wantHeroes: users[:5]},
|
||||
}
|
||||
|
||||
for _, tc := range testCases {
|
||||
t.Run(tc.name, func(t *testing.T) {
|
||||
got, err := table.SelectHeroes(ctx, nil, room.ID, user.ID, tc.memberships)
|
||||
if err != nil {
|
||||
t.Fatalf("unable to select heroes: %s", err)
|
||||
}
|
||||
if gotLen := len(got); gotLen != len(tc.wantHeroes) {
|
||||
t.Fatalf("expected %d heroes, got %d", len(tc.wantHeroes), gotLen)
|
||||
}
|
||||
|
||||
if !reflect.DeepEqual(got, tc.wantHeroes) {
|
||||
t.Fatalf("expected heroes to be %+v, got %+v", tc.wantHeroes, got)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func testMembershipCount(t *testing.T, ctx context.Context, table tables.Memberships, room *test.Room) {
|
||||
t.Run("membership counts are correct", func(t *testing.T) {
|
||||
// After 10 events, we should have 6 users (5 create related [incl. one member event], 5 member events = 6 users)
|
||||
count, err := table.SelectMembershipCount(ctx, nil, room.ID, gomatrixserverlib.Join, 10)
|
||||
if err != nil {
|
||||
t.Fatalf("failed to get membership count: %s", err)
|
||||
}
|
||||
expectedCount := 6
|
||||
if expectedCount != count {
|
||||
t.Fatalf("expected member count to be %d, got %d", expectedCount, count)
|
||||
}
|
||||
|
||||
// After 100 events, we should have all 11 users
|
||||
count, err = table.SelectMembershipCount(ctx, nil, room.ID, gomatrixserverlib.Join, 100)
|
||||
if err != nil {
|
||||
t.Fatalf("failed to get membership count: %s", err)
|
||||
}
|
||||
expectedCount = 11
|
||||
if expectedCount != count {
|
||||
t.Fatalf("expected member count to be %d, got %d", expectedCount, count)
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
func testUpsert(t *testing.T, ctx context.Context, table tables.Memberships, membershipEvent *gomatrixserverlib.HeaderedEvent, user *test.User, room *test.Room) {
|
||||
t.Run("upserting works as expected", func(t *testing.T) {
|
||||
if err := table.UpsertMembership(ctx, nil, membershipEvent, 1, 1); err != nil {
|
||||
t.Fatalf("failed to upsert membership: %s", err)
|
||||
}
|
||||
membership, pos, err := table.SelectMembershipForUser(ctx, nil, room.ID, user.ID, 1)
|
||||
if err != nil {
|
||||
t.Fatalf("failed to select membership: %s", err)
|
||||
}
|
||||
expectedPos := 1
|
||||
if pos != expectedPos {
|
||||
t.Fatalf("expected pos to be %d, got %d", expectedPos, pos)
|
||||
}
|
||||
if membership != gomatrixserverlib.Join {
|
||||
t.Fatalf("expected membership to be join, got %s", membership)
|
||||
}
|
||||
// Create a new event which gets upserted and should not cause issues
|
||||
ev := room.CreateAndInsert(t, user, gomatrixserverlib.MRoomMember, map[string]interface{}{
|
||||
"membership": gomatrixserverlib.Join,
|
||||
}, test.WithStateKey(user.ID))
|
||||
// Insert the same event again, but with different positions, which should get updated
|
||||
if err = table.UpsertMembership(ctx, nil, ev, 2, 2); err != nil {
|
||||
t.Fatalf("failed to upsert membership: %s", err)
|
||||
}
|
||||
|
||||
// Verify the position got updated
|
||||
membership, pos, err = table.SelectMembershipForUser(ctx, nil, room.ID, user.ID, 10)
|
||||
if err != nil {
|
||||
t.Fatalf("failed to select membership: %s", err)
|
||||
}
|
||||
expectedPos = 2
|
||||
if pos != expectedPos {
|
||||
t.Fatalf("expected pos to be %d, got %d", expectedPos, pos)
|
||||
}
|
||||
if membership != gomatrixserverlib.Join {
|
||||
t.Fatalf("expected membership to be join, got %s", membership)
|
||||
}
|
||||
|
||||
// If we can't find a membership, it should default to leave
|
||||
if membership, _, err = table.SelectMembershipForUser(ctx, nil, room.ID, user.ID, 1); err != nil {
|
||||
t.Fatalf("failed to select membership: %s", err)
|
||||
}
|
||||
if membership != gomatrixserverlib.Leave {
|
||||
t.Fatalf("expected membership to be leave, got %s", membership)
|
||||
}
|
||||
})
|
||||
}
|
||||
Loading…
Reference in a new issue