mirror of
https://github.com/matrix-org/dendrite
synced 2024-11-18 15:50:52 +01:00
609f034bfb
* Add setting to enable/disable metrics (#461) Add basic auth to /metric handlers Signed-off-by: Till Faelligen <tfaelligen@gmail.com> * Add warning message if metrics are exposed without protection * Remove redundant type conversion Signed-off-by: Till Faelligen <tfaelligen@gmail.com> * SetBasicAuth per test case * Update warning message and change loglevel to warn * Update common/config/config.go * Update dendrite-config.yaml Co-authored-by: Till Faelligen <tfaelligen@gmail.com> Co-authored-by: Neil Alexander <neilalexander@users.noreply.github.com>
95 lines
1.9 KiB
Go
95 lines
1.9 KiB
Go
package common
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
)
|
|
|
|
func TestWrapHandlerInBasicAuth(t *testing.T) {
|
|
type args struct {
|
|
h http.Handler
|
|
b BasicAuth
|
|
}
|
|
|
|
dummyHandler := http.HandlerFunc(func(h http.ResponseWriter, r *http.Request) {
|
|
h.WriteHeader(http.StatusOK)
|
|
})
|
|
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
want int
|
|
reqAuth bool
|
|
}{
|
|
{
|
|
name: "no user or password setup",
|
|
args: args{h: dummyHandler},
|
|
want: http.StatusOK,
|
|
reqAuth: false,
|
|
},
|
|
{
|
|
name: "only user set",
|
|
args: args{
|
|
h: dummyHandler,
|
|
b: BasicAuth{Username: "test"}, // no basic auth
|
|
},
|
|
want: http.StatusOK,
|
|
reqAuth: false,
|
|
},
|
|
{
|
|
name: "only pass set",
|
|
args: args{
|
|
h: dummyHandler,
|
|
b: BasicAuth{Password: "test"}, // no basic auth
|
|
},
|
|
want: http.StatusOK,
|
|
reqAuth: false,
|
|
},
|
|
{
|
|
name: "credentials correct",
|
|
args: args{
|
|
h: dummyHandler,
|
|
b: BasicAuth{Username: "test", Password: "test"}, // basic auth enabled
|
|
},
|
|
want: http.StatusOK,
|
|
reqAuth: true,
|
|
},
|
|
{
|
|
name: "credentials wrong",
|
|
args: args{
|
|
h: dummyHandler,
|
|
b: BasicAuth{Username: "test1", Password: "test"}, // basic auth enabled
|
|
},
|
|
want: http.StatusForbidden,
|
|
reqAuth: true,
|
|
},
|
|
{
|
|
name: "no basic auth in request",
|
|
args: args{
|
|
h: dummyHandler,
|
|
b: BasicAuth{Username: "test", Password: "test"}, // basic auth enabled
|
|
},
|
|
want: http.StatusForbidden,
|
|
reqAuth: false,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
baHandler := WrapHandlerInBasicAuth(tt.args.h, tt.args.b)
|
|
|
|
req := httptest.NewRequest("GET", "http://localhost/metrics", nil)
|
|
if tt.reqAuth {
|
|
req.SetBasicAuth("test", "test")
|
|
}
|
|
|
|
w := httptest.NewRecorder()
|
|
baHandler(w, req)
|
|
resp := w.Result()
|
|
|
|
if resp.StatusCode != tt.want {
|
|
t.Errorf("Expected status code %d, got %d", resp.StatusCode, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|