0
0
Fork 0
mirror of https://github.com/matrix-org/dendrite synced 2024-11-19 08:10:57 +01:00
dendrite/clientapi/auth
Kegsay c31cb02271
bugfix: Fix a race condition when creating guest accounts (#882)
* bugfix: Fix a race condition when creating guest accounts

It was possible to both select the same next numeric ID and then both
attempt to INSERT this into the table. This would cause a UNIQUE violation
which then presented itself as an error in sqlite because it does not
implement `common.IsUniqueConstraintViolationErr`.

The fix here is NOT to implement `common.IsUniqueConstraintViolationErr`
otherwise the 2 users would get the SAME guest account. Instead, all of
these operations should be done inside a transaction. This is what this
PR does.

* Update postgres

* Typo

* Actually use the txn when creating accounts

* bugfix for database is locked on guest reg
2020-03-06 18:00:07 +00:00
..
authtypes Fix bug in devices endpoint (#877) 2020-02-28 15:06:16 +00:00
storage bugfix: Fix a race condition when creating guest accounts (#882) 2020-03-06 18:00:07 +00:00
auth.go Remove httputil.LogThenError so that the line numbers are reported properly - make error reporting slightly more useful (#879) 2020-03-02 16:20:44 +00:00