mirror of
https://github.com/matrix-org/dendrite
synced 2024-06-13 18:08:59 +02:00
66865597e2
I've found an issue when deploying Dendrite's Helm chart on my local cluster. The template for generating an Ingress resource tries to find the service port using a name (`http`), but the template that generates the Service resource, instead, identifies the resource with a port number. According to the [Kubernetes ServiceSpec](https://kubernetes.io/docs/reference/kubernetes-api/service-resources/service-v1/), `ports.targetPort` can be either a number or a string; if it's the latter, it will be looked up as a named port in the pod's container ports. ### Pull Request Checklist <!-- Please read https://matrix-org.github.io/dendrite/development/contributing before submitting your pull request --> * [x] I have added Go unit tests or [Complement integration tests](https://github.com/matrix-org/complement) for this PR _or_ I have justified why this PR doesn't need tests * [x] Pull request includes a [sign off below using a legally identifiable name](https://matrix-org.github.io/dendrite/development/contributing#sign-off) _or_ I have already signed off privately [skip ci]
17 lines
406 B
YAML
17 lines
406 B
YAML
{{ template "validate.config" . }}
|
|
---
|
|
apiVersion: v1
|
|
kind: Service
|
|
metadata:
|
|
namespace: {{ $.Release.Namespace }}
|
|
name: {{ include "dendrite.fullname" . }}
|
|
labels:
|
|
{{- include "dendrite.labels" . | nindent 4 }}
|
|
spec:
|
|
selector:
|
|
{{- include "dendrite.selectorLabels" . | nindent 4 }}
|
|
ports:
|
|
- name: http
|
|
protocol: TCP
|
|
port: {{ .Values.service.port }}
|
|
targetPort: http |