mirror of
https://github.com/matrix-org/dendrite
synced 2024-12-16 10:13:41 +01:00
f05ce478f0
* Add Pushserver component with Pushers API Co-authored-by: Tommie Gannert <tommie@gannert.se> Co-authored-by: Dan Peleg <dan@globekeeper.com> * Wire Pushserver component Co-authored-by: Neil Alexander <neilalexander@users.noreply.github.com> * Add PushGatewayClient. The full event format is required for Sytest. * Add a pushrules module. * Change user API account creation to use the new pushrules module's defaults. Introduces "scope" as required by client API, and some small field tweaks to make some 61push Sytests pass. * Add push rules query/put API in Pushserver. This manipulates account data over User API, and fires sync messages for changes. Those sync messages should, according to an existing TODO in clientapi, be moved to userapi. Forks clientapi/producers/syncapi.go to pushserver/ for later extension. * Add clientapi routes for push rules to Pushserver. A cleanup would be to move more of the name-splitting logic into pushrules.go, to depollute routing.go. * Output rooms.join.unread_notifications in /sync. This is the read-side. Pushserver will be the write-side. * Implement pushserver/storage for notifications. * Use PushGatewayClient and the pushrules module in Pushserver's room consumer. * Use one goroutine per user to avoid locking up the entire server for one bad push gateway. * Split pushing by format. * Send one device per push. Sytest does not support coalescing multiple devices into one push. Matches Synapse. Either we change Sytest, or remove the group-by-url-and-format logic. * Write OutputNotificationData from push server. Sync API is already the consumer. * Implement read receipt consumers in Pushserver. Supports m.read and m.fully_read receipts. * Add clientapi route for /unstable/notifications. * Rename to UpsertPusher for clarity and handle pusher update * Fix linter errors * Ignore body.Close() error check * Fix push server internal http wiring * Add 40 newly passing 61push tests to whitelist * Add next 12 newly passing 61push tests to whitelist * Send notification data before notifying users in EDU server consumer * NATS JetStream * Goodbye sarama * Fix `NewStreamTokenFromString` * Consume on the correct topic for the roomserver * Don't panic, NAK instead * Move push notifications into the User API * Don't set null values since that apparently causes Element upsetti * Also set omitempty on conditions * Fix bug so that we don't override the push rules unnecessarily * Tweak defaults * Update defaults * More tweaks * Move `/notifications` onto `r0`/`v3` mux * User API will consume events and read/fully read markers from the sync API with stream positions, instead of consuming directly Co-authored-by: Piotr Kozimor <p1996k@gmail.com> Co-authored-by: Tommie Gannert <tommie@gannert.se> Co-authored-by: Neil Alexander <neilalexander@users.noreply.github.com>
85 lines
2 KiB
Go
85 lines
2 KiB
Go
package pushrules
|
|
|
|
import (
|
|
"fmt"
|
|
"regexp"
|
|
)
|
|
|
|
// ValidateRule checks the rule for errors. These follow from Sytests
|
|
// and the specification.
|
|
func ValidateRule(kind Kind, rule *Rule) []error {
|
|
var errs []error
|
|
|
|
if !validRuleIDRE.MatchString(rule.RuleID) {
|
|
errs = append(errs, fmt.Errorf("invalid rule ID: %s", rule.RuleID))
|
|
}
|
|
|
|
if len(rule.Actions) == 0 {
|
|
errs = append(errs, fmt.Errorf("missing actions"))
|
|
}
|
|
for _, action := range rule.Actions {
|
|
errs = append(errs, validateAction(action)...)
|
|
}
|
|
|
|
for _, cond := range rule.Conditions {
|
|
errs = append(errs, validateCondition(cond)...)
|
|
}
|
|
|
|
switch kind {
|
|
case OverrideKind, UnderrideKind:
|
|
// The empty list is allowed, but for JSON-encoding reasons,
|
|
// it must not be nil.
|
|
if rule.Conditions == nil {
|
|
errs = append(errs, fmt.Errorf("missing rule conditions"))
|
|
}
|
|
|
|
case ContentKind:
|
|
if rule.Pattern == "" {
|
|
errs = append(errs, fmt.Errorf("missing content rule pattern"))
|
|
}
|
|
|
|
case RoomKind, SenderKind:
|
|
// Do nothing.
|
|
|
|
default:
|
|
errs = append(errs, fmt.Errorf("invalid rule kind: %s", kind))
|
|
}
|
|
|
|
return errs
|
|
}
|
|
|
|
// validRuleIDRE is a regexp for valid IDs.
|
|
//
|
|
// TODO: the specification doesn't seem to say what the rule ID syntax
|
|
// is. A Sytest fails if it contains a backslash.
|
|
var validRuleIDRE = regexp.MustCompile(`^([^\\]+)$`)
|
|
|
|
// validateAction returns issues with an Action.
|
|
func validateAction(action *Action) []error {
|
|
var errs []error
|
|
|
|
switch action.Kind {
|
|
case NotifyAction, DontNotifyAction, CoalesceAction, SetTweakAction:
|
|
// Do nothing.
|
|
|
|
default:
|
|
errs = append(errs, fmt.Errorf("invalid rule action kind: %s", action.Kind))
|
|
}
|
|
|
|
return errs
|
|
}
|
|
|
|
// validateCondition returns issues with a Condition.
|
|
func validateCondition(cond *Condition) []error {
|
|
var errs []error
|
|
|
|
switch cond.Kind {
|
|
case EventMatchCondition, ContainsDisplayNameCondition, RoomMemberCountCondition, SenderNotificationPermissionCondition:
|
|
// Do nothing.
|
|
|
|
default:
|
|
errs = append(errs, fmt.Errorf("invalid rule condition kind: %s", cond.Kind))
|
|
}
|
|
|
|
return errs
|
|
}
|