mirror of
https://github.com/matrix-org/dendrite
synced 2024-08-15 00:25:01 +02:00
The stale device lists table might contain entries for users we don't share a room with anymore. This now asks the roomserver about left users and removes those entries from the table. Co-authored-by: Neil Alexander <neilalexander@users.noreply.github.com>
140 lines
5 KiB
Go
140 lines
5 KiB
Go
package tables_test
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/matrix-org/dendrite/internal/sqlutil"
|
|
"github.com/matrix-org/dendrite/roomserver/storage/postgres"
|
|
"github.com/matrix-org/dendrite/roomserver/storage/sqlite3"
|
|
"github.com/matrix-org/dendrite/roomserver/storage/tables"
|
|
"github.com/matrix-org/dendrite/roomserver/types"
|
|
"github.com/matrix-org/dendrite/setup/config"
|
|
"github.com/matrix-org/dendrite/test"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func mustCreateMembershipTable(t *testing.T, dbType test.DBType) (tab tables.Membership, stateKeyTab tables.EventStateKeys, close func()) {
|
|
t.Helper()
|
|
connStr, close := test.PrepareDBConnectionString(t, dbType)
|
|
db, err := sqlutil.Open(&config.DatabaseOptions{
|
|
ConnectionString: config.DataSource(connStr),
|
|
}, sqlutil.NewExclusiveWriter())
|
|
assert.NoError(t, err)
|
|
switch dbType {
|
|
case test.DBTypePostgres:
|
|
err = postgres.CreateEventStateKeysTable(db)
|
|
assert.NoError(t, err)
|
|
err = postgres.CreateMembershipTable(db)
|
|
assert.NoError(t, err)
|
|
tab, err = postgres.PrepareMembershipTable(db)
|
|
assert.NoError(t, err)
|
|
stateKeyTab, err = postgres.PrepareEventStateKeysTable(db)
|
|
case test.DBTypeSQLite:
|
|
err = sqlite3.CreateEventStateKeysTable(db)
|
|
assert.NoError(t, err)
|
|
err = sqlite3.CreateMembershipTable(db)
|
|
assert.NoError(t, err)
|
|
tab, err = sqlite3.PrepareMembershipTable(db)
|
|
assert.NoError(t, err)
|
|
stateKeyTab, err = sqlite3.PrepareEventStateKeysTable(db)
|
|
}
|
|
assert.NoError(t, err)
|
|
|
|
return tab, stateKeyTab, close
|
|
}
|
|
|
|
func TestMembershipTable(t *testing.T) {
|
|
ctx := context.Background()
|
|
test.WithAllDatabases(t, func(t *testing.T, dbType test.DBType) {
|
|
tab, stateKeyTab, close := mustCreateMembershipTable(t, dbType)
|
|
defer close()
|
|
_ = close
|
|
|
|
userNIDs := make([]types.EventStateKeyNID, 0, 10)
|
|
for i := 0; i < 10; i++ {
|
|
stateKeyNID, err := stateKeyTab.InsertEventStateKeyNID(ctx, nil, fmt.Sprintf("@dummy%d:localhost", i))
|
|
assert.NoError(t, err)
|
|
userNIDs = append(userNIDs, stateKeyNID)
|
|
// This inserts a left user to the room
|
|
err = tab.InsertMembership(ctx, nil, 1, stateKeyNID, true)
|
|
assert.NoError(t, err)
|
|
// We must update the membership with a non-zero event NID or it will get filtered out in later queries
|
|
_, err = tab.UpdateMembership(ctx, nil, 1, stateKeyNID, userNIDs[0], tables.MembershipStateLeaveOrBan, 1, false)
|
|
assert.NoError(t, err)
|
|
}
|
|
|
|
// ... so this should be false
|
|
inRoom, err := tab.SelectLocalServerInRoom(ctx, nil, 1)
|
|
assert.NoError(t, err)
|
|
assert.False(t, inRoom)
|
|
|
|
changed, err := tab.UpdateMembership(ctx, nil, 1, userNIDs[0], userNIDs[0], tables.MembershipStateJoin, 1, false)
|
|
assert.NoError(t, err)
|
|
assert.True(t, changed)
|
|
|
|
// ... should now be true
|
|
inRoom, err = tab.SelectLocalServerInRoom(ctx, nil, 1)
|
|
assert.NoError(t, err)
|
|
assert.True(t, inRoom)
|
|
|
|
userJoinedToRooms, err := tab.SelectJoinedUsersSetForRooms(ctx, nil, []types.RoomNID{1}, userNIDs, false)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 1, len(userJoinedToRooms))
|
|
|
|
// Get all left/banned users
|
|
eventNIDs, err := tab.SelectMembershipsFromRoomAndMembership(ctx, nil, 1, tables.MembershipStateLeaveOrBan, true)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 9, len(eventNIDs))
|
|
|
|
_, membershipState, forgotten, err := tab.SelectMembershipFromRoomAndTarget(ctx, nil, 1, userNIDs[5])
|
|
assert.NoError(t, err)
|
|
assert.False(t, forgotten)
|
|
assert.Equal(t, tables.MembershipStateLeaveOrBan, membershipState)
|
|
|
|
// Get all members, regardless of state
|
|
members, err := tab.SelectMembershipsFromRoom(ctx, nil, 1, true)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 10, len(members))
|
|
|
|
// Get correct user
|
|
roomNIDs, err := tab.SelectRoomsWithMembership(ctx, nil, userNIDs[1], tables.MembershipStateLeaveOrBan)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, []types.RoomNID{1}, roomNIDs)
|
|
|
|
// User is not joined to room
|
|
roomNIDs, err = tab.SelectRoomsWithMembership(ctx, nil, userNIDs[5], tables.MembershipStateJoin)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 0, len(roomNIDs))
|
|
|
|
// Forget room
|
|
err = tab.UpdateForgetMembership(ctx, nil, 1, userNIDs[0], true)
|
|
assert.NoError(t, err)
|
|
|
|
// should now return true
|
|
_, _, forgotten, err = tab.SelectMembershipFromRoomAndTarget(ctx, nil, 1, userNIDs[0])
|
|
assert.NoError(t, err)
|
|
assert.True(t, forgotten)
|
|
|
|
serverInRoom, err := tab.SelectServerInRoom(ctx, nil, 1, "localhost")
|
|
assert.NoError(t, err)
|
|
assert.True(t, serverInRoom)
|
|
|
|
serverInRoom, err = tab.SelectServerInRoom(ctx, nil, 1, "notJoined")
|
|
assert.NoError(t, err)
|
|
assert.False(t, serverInRoom)
|
|
|
|
// get all users we know about; should be only one user, since no other user joined the room
|
|
knownUsers, err := tab.SelectKnownUsers(ctx, nil, userNIDs[0], "localhost", 2)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 1, len(knownUsers))
|
|
|
|
// get users we share a room with, given their userNID
|
|
joinedUsers, err := tab.SelectJoinedUsers(ctx, nil, userNIDs)
|
|
assert.NoError(t, err)
|
|
// Only userNIDs[0] is actually joined, so we only expect this userNID
|
|
assert.Equal(t, userNIDs[:1], joinedUsers)
|
|
})
|
|
}
|