mirror of
https://github.com/matrix-org/dendrite
synced 2024-12-15 12:53:43 +01:00
eb352a5f6b
* Add transaction to all database tables in roomserver, rename latest events updater to room updater, use room updater for all RS input
* Better transaction management
* Tweak order
* Handle cases where the room does not exist
* Other fixes
* More tweaks
* Fill some gaps
* Fill in the gaps
* good lord it gets worse
* Don't roll back transactions when events rejected
* Pass through errors properly
* Fix bugs
* Fix incorrect error check
* Don't panic on nil txns
* Tweaks
* Hopefully fix panics for good in SQLite this time
* Fix rollback
* Minor bug fixes with latest event updater
* Some review comments
* Revert "Some review comments"
This reverts commit 0caf8cf53e
.
* Fix a couple of bugs
* Clearer commit and rollback results
* Remove unnecessary prepares
227 lines
6.6 KiB
Go
227 lines
6.6 KiB
Go
// Copyright 2017-2018 New Vector Ltd
|
|
// Copyright 2019-2020 The Matrix.org Foundation C.I.C.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package sqlite3
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
|
|
"github.com/matrix-org/dendrite/internal/caching"
|
|
"github.com/matrix-org/dendrite/internal/sqlutil"
|
|
"github.com/matrix-org/dendrite/roomserver/storage/shared"
|
|
"github.com/matrix-org/dendrite/roomserver/storage/sqlite3/deltas"
|
|
"github.com/matrix-org/dendrite/roomserver/types"
|
|
"github.com/matrix-org/dendrite/setup/config"
|
|
"github.com/matrix-org/gomatrixserverlib"
|
|
)
|
|
|
|
// A Database is used to store room events and stream offsets.
|
|
type Database struct {
|
|
shared.Database
|
|
}
|
|
|
|
// Open a sqlite database.
|
|
func Open(dbProperties *config.DatabaseOptions, cache caching.RoomServerCaches) (*Database, error) {
|
|
var d Database
|
|
var db *sql.DB
|
|
var err error
|
|
if db, err = sqlutil.Open(dbProperties); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
//db.Exec("PRAGMA journal_mode=WAL;")
|
|
//db.Exec("PRAGMA read_uncommitted = true;")
|
|
|
|
// FIXME: We are leaking connections somewhere. Setting this to 2 will eventually
|
|
// cause the roomserver to be unresponsive to new events because something will
|
|
// acquire the global mutex and never unlock it because it is waiting for a connection
|
|
// which it will never obtain.
|
|
db.SetMaxOpenConns(20)
|
|
|
|
// Create the tables.
|
|
if err := d.create(db); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Then execute the migrations. By this point the tables are created with the latest
|
|
// schemas.
|
|
m := sqlutil.NewMigrations()
|
|
deltas.LoadAddForgottenColumn(m)
|
|
deltas.LoadStateBlocksRefactor(m)
|
|
if err := m.RunDeltas(db, dbProperties); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Then prepare the statements. Now that the migrations have run, any columns referred
|
|
// to in the database code should now exist.
|
|
if err := d.prepare(db, cache); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return &d, nil
|
|
}
|
|
|
|
func (d *Database) create(db *sql.DB) error {
|
|
if err := createEventStateKeysTable(db); err != nil {
|
|
return err
|
|
}
|
|
if err := createEventTypesTable(db); err != nil {
|
|
return err
|
|
}
|
|
if err := createEventJSONTable(db); err != nil {
|
|
return err
|
|
}
|
|
if err := createEventsTable(db); err != nil {
|
|
return err
|
|
}
|
|
if err := createRoomsTable(db); err != nil {
|
|
return err
|
|
}
|
|
if err := createStateBlockTable(db); err != nil {
|
|
return err
|
|
}
|
|
if err := createStateSnapshotTable(db); err != nil {
|
|
return err
|
|
}
|
|
if err := createPrevEventsTable(db); err != nil {
|
|
return err
|
|
}
|
|
if err := createRoomAliasesTable(db); err != nil {
|
|
return err
|
|
}
|
|
if err := createInvitesTable(db); err != nil {
|
|
return err
|
|
}
|
|
if err := createMembershipTable(db); err != nil {
|
|
return err
|
|
}
|
|
if err := createPublishedTable(db); err != nil {
|
|
return err
|
|
}
|
|
if err := createRedactionsTable(db); err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (d *Database) prepare(db *sql.DB, cache caching.RoomServerCaches) error {
|
|
eventStateKeys, err := prepareEventStateKeysTable(db)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
eventTypes, err := prepareEventTypesTable(db)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
eventJSON, err := prepareEventJSONTable(db)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
events, err := prepareEventsTable(db)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
rooms, err := prepareRoomsTable(db)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
stateBlock, err := prepareStateBlockTable(db)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
stateSnapshot, err := prepareStateSnapshotTable(db)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
prevEvents, err := preparePrevEventsTable(db)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
roomAliases, err := prepareRoomAliasesTable(db)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
invites, err := prepareInvitesTable(db)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
membership, err := prepareMembershipTable(db)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
published, err := preparePublishedTable(db)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
redactions, err := prepareRedactionsTable(db)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
d.Database = shared.Database{
|
|
DB: db,
|
|
Cache: cache,
|
|
Writer: sqlutil.NewExclusiveWriter(),
|
|
EventsTable: events,
|
|
EventTypesTable: eventTypes,
|
|
EventStateKeysTable: eventStateKeys,
|
|
EventJSONTable: eventJSON,
|
|
RoomsTable: rooms,
|
|
StateBlockTable: stateBlock,
|
|
StateSnapshotTable: stateSnapshot,
|
|
PrevEventsTable: prevEvents,
|
|
RoomAliasesTable: roomAliases,
|
|
InvitesTable: invites,
|
|
MembershipTable: membership,
|
|
PublishedTable: published,
|
|
RedactionsTable: redactions,
|
|
GetRoomUpdaterFn: d.GetRoomUpdater,
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (d *Database) SupportsConcurrentRoomInputs() bool {
|
|
// This isn't supported in SQLite mode yet because of issues with
|
|
// database locks.
|
|
// TODO: Look at this again - the problem is probably to do with
|
|
// the membership updaters and latest events updaters.
|
|
return false
|
|
}
|
|
|
|
func (d *Database) GetRoomUpdater(
|
|
ctx context.Context, roomInfo *types.RoomInfo,
|
|
) (*shared.RoomUpdater, error) {
|
|
// TODO: Do not use transactions. We should be holding open this transaction but we cannot have
|
|
// multiple write transactions on sqlite. The code will perform additional
|
|
// write transactions independent of this one which will consistently cause
|
|
// 'database is locked' errors. As sqlite doesn't support multi-process on the
|
|
// same DB anyway, and we only execute updates sequentially, the only worries
|
|
// are for rolling back when things go wrong. (atomicity)
|
|
return shared.NewRoomUpdater(ctx, &d.Database, nil, roomInfo)
|
|
}
|
|
|
|
func (d *Database) MembershipUpdater(
|
|
ctx context.Context, roomID, targetUserID string,
|
|
targetLocal bool, roomVersion gomatrixserverlib.RoomVersion,
|
|
) (*shared.MembershipUpdater, error) {
|
|
// TODO: Do not use transactions. We should be holding open this transaction but we cannot have
|
|
// multiple write transactions on sqlite. The code will perform additional
|
|
// write transactions independent of this one which will consistently cause
|
|
// 'database is locked' errors. As sqlite doesn't support multi-process on the
|
|
// same DB anyway, and we only execute updates sequentially, the only worries
|
|
// are for rolling back when things go wrong. (atomicity)
|
|
return shared.NewMembershipUpdater(ctx, &d.Database, nil, roomID, targetUserID, targetLocal, roomVersion)
|
|
}
|