dendrite

mirror of https://github.com/matrix-org/dendrite synced 2024-11-18 15:50:52 +01:00

History

Andrew Morgan 33a1392541 Encode URLs properly (#728 ) We were escaping the URL before performing any pattern matching on it. This meant that if you sent data that URLdecoded to a "/", it would count as a "/" in the URL, potentially causing a 404. This was causing some flaky tests with some randomly-generated query parameters. Now, we keep URLs encoded while doing the pattern matching, and only afterwards do we URL decode each query parameter individually before passing them to their respective handler functions. github.com/gorilla/mux was also updated to v1.7.3 to fix a bug with URL encoding and subrouters.	2019-07-03 16:38:50 +01:00
..
routing.go	Encode URLs properly (#728 )	2019-07-03 16:38:50 +01:00

We were escaping the URL before performing any pattern matching on it.
This meant that if you sent data that URLdecoded to a "/", it would count as
a "/" in the URL, potentially causing a 404. This was causing some flaky tests
with some randomly-generated query parameters.

Now, we keep URLs encoded while doing the pattern matching, and only afterwards
do we URL decode each query parameter individually before passing them to their
respective handler functions.

github.com/gorilla/mux was also updated to v1.7.3 to fix a bug with URL encoding and subrouters.

2019-07-03 16:38:50 +01:00

routing.go

Encode URLs properly (#728 )

2019-07-03 16:38:50 +01:00