mirror of
https://github.com/matrix-org/dendrite
synced 2024-11-06 16:09:01 +01:00
c36e4546c3
* Add GOPATH to PATH in find-lint.sh. The user doesn't necessarily have it in PATH. * Refactor LoginTypePassword and Type to support m.login.token and m.login.sso. For login token: * m.login.token will require deleting the token after completeAuth has generated an access token, so a cleanup function is returned by Type.Login. * Allowing different login types will require parsing the /login body twice: first to extract the "type" and then the type-specific parsing. Thus, we will have to buffer the request JSON in /login, like UserInteractive already does. For SSO: * NewUserInteractive will have to also use GetAccountByLocalpart. It makes more sense to just pass a (narrowed-down) accountDB interface to it than adding more function pointers. Code quality: * Passing around (and down-casting) interface{} for login request types has drawbacks in terms of type-safety, and no inherent benefits. We always decode JSON anyway. Hence renaming to Type.LoginFromJSON. Code that directly uses LoginTypePassword with parsed data can still use Login. * Removed a TODO for SSO. This is already tracked in #1297. * httputil.UnmarshalJSON is useful because it returns a JSONResponse. This change is intended to have no functional changes. * Support login tokens in User API. This adds full lifecycle functions for login tokens: create, query, delete. * Support m.login.token in /login. * Fixes for PR review. * Set @matrix-org/dendrite-core as repository code owner * Return event NID from `StoreEvent`, match PSQL vs SQLite behaviour, tweak backfill persistence (#2071) Co-authored-by: kegsay <kegan@matrix.org> Co-authored-by: Neil Alexander <neilalexander@users.noreply.github.com>
194 lines
5 KiB
Go
194 lines
5 KiB
Go
// Copyright 2021 The Matrix.org Foundation C.I.C.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package auth
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"net/http"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/matrix-org/dendrite/clientapi/jsonerror"
|
|
"github.com/matrix-org/dendrite/setup/config"
|
|
uapi "github.com/matrix-org/dendrite/userapi/api"
|
|
"github.com/matrix-org/util"
|
|
)
|
|
|
|
func TestLoginFromJSONReader(t *testing.T) {
|
|
ctx := context.Background()
|
|
|
|
tsts := []struct {
|
|
Name string
|
|
Body string
|
|
|
|
WantUsername string
|
|
WantDeviceID string
|
|
WantDeletedTokens []string
|
|
}{
|
|
{
|
|
Name: "passwordWorks",
|
|
Body: `{
|
|
"type": "m.login.password",
|
|
"identifier": { "type": "m.id.user", "user": "alice" },
|
|
"password": "herpassword",
|
|
"device_id": "adevice"
|
|
}`,
|
|
WantUsername: "alice",
|
|
WantDeviceID: "adevice",
|
|
},
|
|
{
|
|
Name: "tokenWorks",
|
|
Body: `{
|
|
"type": "m.login.token",
|
|
"token": "atoken",
|
|
"device_id": "adevice"
|
|
}`,
|
|
WantUsername: "@auser:example.com",
|
|
WantDeviceID: "adevice",
|
|
WantDeletedTokens: []string{"atoken"},
|
|
},
|
|
}
|
|
for _, tst := range tsts {
|
|
t.Run(tst.Name, func(t *testing.T) {
|
|
var accountDB fakeAccountDB
|
|
var userAPI fakeUserInternalAPI
|
|
cfg := &config.ClientAPI{
|
|
Matrix: &config.Global{
|
|
ServerName: serverName,
|
|
},
|
|
}
|
|
login, cleanup, err := LoginFromJSONReader(ctx, strings.NewReader(tst.Body), &accountDB, &userAPI, cfg)
|
|
if err != nil {
|
|
t.Fatalf("LoginFromJSONReader failed: %+v", err)
|
|
}
|
|
cleanup(ctx, &util.JSONResponse{Code: http.StatusOK})
|
|
|
|
if login.Username() != tst.WantUsername {
|
|
t.Errorf("Username: got %q, want %q", login.Username(), tst.WantUsername)
|
|
}
|
|
|
|
if login.DeviceID == nil {
|
|
if tst.WantDeviceID != "" {
|
|
t.Errorf("DeviceID: got %v, want %q", login.DeviceID, tst.WantDeviceID)
|
|
}
|
|
} else {
|
|
if *login.DeviceID != tst.WantDeviceID {
|
|
t.Errorf("DeviceID: got %q, want %q", *login.DeviceID, tst.WantDeviceID)
|
|
}
|
|
}
|
|
|
|
if !reflect.DeepEqual(userAPI.DeletedTokens, tst.WantDeletedTokens) {
|
|
t.Errorf("DeletedTokens: got %+v, want %+v", userAPI.DeletedTokens, tst.WantDeletedTokens)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestBadLoginFromJSONReader(t *testing.T) {
|
|
ctx := context.Background()
|
|
|
|
tsts := []struct {
|
|
Name string
|
|
Body string
|
|
|
|
WantErrCode string
|
|
}{
|
|
{Name: "empty", WantErrCode: "M_BAD_JSON"},
|
|
{
|
|
Name: "badUnmarshal",
|
|
Body: `badsyntaxJSON`,
|
|
WantErrCode: "M_BAD_JSON",
|
|
},
|
|
{
|
|
Name: "badPassword",
|
|
Body: `{
|
|
"type": "m.login.password",
|
|
"identifier": { "type": "m.id.user", "user": "alice" },
|
|
"password": "invalidpassword",
|
|
"device_id": "adevice"
|
|
}`,
|
|
WantErrCode: "M_FORBIDDEN",
|
|
},
|
|
{
|
|
Name: "badToken",
|
|
Body: `{
|
|
"type": "m.login.token",
|
|
"token": "invalidtoken",
|
|
"device_id": "adevice"
|
|
}`,
|
|
WantErrCode: "M_FORBIDDEN",
|
|
},
|
|
{
|
|
Name: "badType",
|
|
Body: `{
|
|
"type": "m.login.invalid",
|
|
"device_id": "adevice"
|
|
}`,
|
|
WantErrCode: "M_INVALID_ARGUMENT_VALUE",
|
|
},
|
|
}
|
|
for _, tst := range tsts {
|
|
t.Run(tst.Name, func(t *testing.T) {
|
|
var accountDB fakeAccountDB
|
|
var userAPI fakeUserInternalAPI
|
|
cfg := &config.ClientAPI{
|
|
Matrix: &config.Global{
|
|
ServerName: serverName,
|
|
},
|
|
}
|
|
_, cleanup, errRes := LoginFromJSONReader(ctx, strings.NewReader(tst.Body), &accountDB, &userAPI, cfg)
|
|
if errRes == nil {
|
|
cleanup(ctx, nil)
|
|
t.Fatalf("LoginFromJSONReader err: got %+v, want code %q", errRes, tst.WantErrCode)
|
|
} else if merr, ok := errRes.JSON.(*jsonerror.MatrixError); ok && merr.ErrCode != tst.WantErrCode {
|
|
t.Fatalf("LoginFromJSONReader err: got %+v, want code %q", errRes, tst.WantErrCode)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
type fakeAccountDB struct {
|
|
AccountDatabase
|
|
}
|
|
|
|
func (*fakeAccountDB) GetAccountByPassword(ctx context.Context, localpart, password string) (*uapi.Account, error) {
|
|
if password == "invalidpassword" {
|
|
return nil, sql.ErrNoRows
|
|
}
|
|
|
|
return &uapi.Account{}, nil
|
|
}
|
|
|
|
type fakeUserInternalAPI struct {
|
|
UserInternalAPIForLogin
|
|
|
|
DeletedTokens []string
|
|
}
|
|
|
|
func (ua *fakeUserInternalAPI) PerformLoginTokenDeletion(ctx context.Context, req *uapi.PerformLoginTokenDeletionRequest, res *uapi.PerformLoginTokenDeletionResponse) error {
|
|
ua.DeletedTokens = append(ua.DeletedTokens, req.Token)
|
|
return nil
|
|
}
|
|
|
|
func (*fakeUserInternalAPI) QueryLoginToken(ctx context.Context, req *uapi.QueryLoginTokenRequest, res *uapi.QueryLoginTokenResponse) error {
|
|
if req.Token == "invalidtoken" {
|
|
return nil
|
|
}
|
|
|
|
res.Data = &uapi.LoginTokenData{UserID: "@auser:example.com"}
|
|
return nil
|
|
}
|