mirror of
https://github.com/matrix-org/dendrite
synced 2024-12-23 22:53:47 +01:00
c36e4546c3
* Add GOPATH to PATH in find-lint.sh.
The user doesn't necessarily have it in PATH.
* Refactor LoginTypePassword and Type to support m.login.token and m.login.sso.
For login token:
* m.login.token will require deleting the token after completeAuth has
generated an access token, so a cleanup function is returned by
Type.Login.
* Allowing different login types will require parsing the /login body
twice: first to extract the "type" and then the type-specific parsing.
Thus, we will have to buffer the request JSON in /login, like
UserInteractive already does.
For SSO:
* NewUserInteractive will have to also use GetAccountByLocalpart. It
makes more sense to just pass a (narrowed-down) accountDB interface
to it than adding more function pointers.
Code quality:
* Passing around (and down-casting) interface{} for login request types
has drawbacks in terms of type-safety, and no inherent benefits. We
always decode JSON anyway. Hence renaming to Type.LoginFromJSON. Code
that directly uses LoginTypePassword with parsed data can still use
Login.
* Removed a TODO for SSO. This is already tracked in #1297.
* httputil.UnmarshalJSON is useful because it returns a JSONResponse.
This change is intended to have no functional changes.
* Support login tokens in User API.
This adds full lifecycle functions for login tokens: create, query, delete.
* Support m.login.token in /login.
* Fixes for PR review.
* Set @matrix-org/dendrite-core as repository code owner
* Return event NID from `StoreEvent`, match PSQL vs SQLite behaviour, tweak backfill persistence (#2071)
Co-authored-by: kegsay <kegan@matrix.org>
Co-authored-by: Neil Alexander <neilalexander@users.noreply.github.com>
41 lines
1 KiB
Bash
Executable file
41 lines
1 KiB
Bash
Executable file
#! /bin/bash
|
|
|
|
# Runs the linters against dendrite
|
|
|
|
# The linters can take a lot of resources and are slow, so they can be
|
|
# configured using the following environment variables:
|
|
#
|
|
# - `DENDRITE_LINT_CONCURRENCY` - number of concurrent linters to run,
|
|
# golangci-lint defaults this to NumCPU
|
|
# - `GOGC` - how often to perform garbage collection during golangci-lint runs.
|
|
# Essentially a ratio of memory/speed. See https://golangci-lint.run/usage/performance/#memory-usage
|
|
# for more info.
|
|
|
|
|
|
set -eux
|
|
|
|
cd `dirname $0`/../..
|
|
|
|
args=""
|
|
if [ ${1:-""} = "fast" ]
|
|
then args="--fast"
|
|
fi
|
|
|
|
echo "Installing golangci-lint..."
|
|
|
|
# Make a backup of go.{mod,sum} first
|
|
cp go.mod go.mod.bak && cp go.sum go.sum.bak
|
|
go get github.com/golangci/golangci-lint/cmd/golangci-lint@v1.41.1
|
|
|
|
# Run linting
|
|
echo "Looking for lint..."
|
|
|
|
# Capture exit code to ensure go.{mod,sum} is restored before exiting
|
|
exit_code=0
|
|
|
|
PATH="$PATH:${GOPATH:-~/go}/bin" golangci-lint run $args || exit_code=1
|
|
|
|
# Restore go.{mod,sum}
|
|
mv go.mod.bak go.mod && mv go.sum.bak go.sum
|
|
|
|
exit $exit_code
|