0
0
Fork 0
mirror of https://github.com/matrix-org/dendrite synced 2024-12-20 19:13:47 +01:00
dendrite/syncapi/storage/postgres
Kiril Vladimiroff d5dbe546e4
Always defer *sql.Rows.Close and consult with Err ()
* Always defer *sql.Rows.Close and consult with Err

database/sql.Rows.Next() makes sure to call Close only after exhausting
result rows which would NOT happen when returning early from a bad Scan.
Close being idempotent makes it a great candidate to get always deferred
regardless of what happens later on the result set.

This change also makes sure call Err() after exhausting Next() and
propagate non-nil results from it as the documentation advises.

Closes 

Signed-off-by: Kiril Vladimiroff <kiril@vladimiroff.org>

* Override named result parameters in last returns

Signed-off-by: Kiril Vladimiroff <kiril@vladimiroff.org>

* Do the same over new changes that got merged

Signed-off-by: Kiril Vladimiroff <kiril@vladimiroff.org>

Co-authored-by: Neil Alexander <neilalexander@users.noreply.github.com>
2020-02-11 14:12:21 +00:00
..
account_data_table.go Always defer *sql.Rows.Close and consult with Err () 2020-02-11 14:12:21 +00:00
backward_extremities_table.go Always defer *sql.Rows.Close and consult with Err () 2020-02-11 14:12:21 +00:00
current_room_state_table.go Always defer *sql.Rows.Close and consult with Err () 2020-02-11 14:12:21 +00:00
filtering.go Implement storage interfaces () 2020-01-03 14:07:05 +00:00
invites_table.go Always defer *sql.Rows.Close and consult with Err () 2020-02-11 14:12:21 +00:00
output_room_events_table.go Always defer *sql.Rows.Close and consult with Err () 2020-02-11 14:12:21 +00:00
output_room_events_topology_table.go Always defer *sql.Rows.Close and consult with Err () 2020-02-11 14:12:21 +00:00
syncserver.go More sync fixes () 2020-01-25 14:23:16 +00:00