mirror of
https://github.com/matrix-org/dendrite
synced 2024-11-14 22:01:13 +01:00
eb29a31550
Should fix the following issues or make a lot less worse when using Postgres: The main issue behind #2911: The client gives up after a certain time, causing a cascade of context errors, because the response couldn't be built up fast enough. This mostly happens on accounts with many rooms, due to the inefficient way we're getting recent events and current state For #2777: The queries for getting the membership events for history visibility were being executed for each room (I think 185?), resulting in a whooping 2k queries for membership events. (Getting the statesnapshot -> block nids -> actual wanted membership event) Both should now be better by: - Using a LATERAL join to get all recent events for all joined rooms in one go (TODO: maybe do the same for room summary and current state etc) - If we're lazy loading on initial syncs, we're now not getting the whole current state, just to drop the majority of it because we're lazy loading members - we add a filter to exclude membership events on the first call to `CurrentState`. - Using an optimized query to get the membership events needed to calculate history visibility --------- Co-authored-by: kegsay <kegan@matrix.org>
72 lines
1.3 KiB
Go
72 lines
1.3 KiB
Go
package shared
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/matrix-org/gomatrixserverlib"
|
|
)
|
|
|
|
func Test_isStatefilterEmpty(t *testing.T) {
|
|
filterSet := []string{"a"}
|
|
boolValue := false
|
|
|
|
tests := []struct {
|
|
name string
|
|
filter *gomatrixserverlib.StateFilter
|
|
want bool
|
|
}{
|
|
{
|
|
name: "nil filter is empty",
|
|
filter: nil,
|
|
want: true,
|
|
},
|
|
{
|
|
name: "Empty filter is empty",
|
|
filter: &gomatrixserverlib.StateFilter{},
|
|
want: true,
|
|
},
|
|
{
|
|
name: "NotTypes is set",
|
|
filter: &gomatrixserverlib.StateFilter{
|
|
NotTypes: &filterSet,
|
|
},
|
|
},
|
|
{
|
|
name: "Types is set",
|
|
filter: &gomatrixserverlib.StateFilter{
|
|
Types: &filterSet,
|
|
},
|
|
},
|
|
{
|
|
name: "Senders is set",
|
|
filter: &gomatrixserverlib.StateFilter{
|
|
Senders: &filterSet,
|
|
},
|
|
},
|
|
{
|
|
name: "NotSenders is set",
|
|
filter: &gomatrixserverlib.StateFilter{
|
|
NotSenders: &filterSet,
|
|
},
|
|
},
|
|
{
|
|
name: "NotRooms is set",
|
|
filter: &gomatrixserverlib.StateFilter{
|
|
NotRooms: &filterSet,
|
|
},
|
|
},
|
|
{
|
|
name: "ContainsURL is set",
|
|
filter: &gomatrixserverlib.StateFilter{
|
|
ContainsURL: &boolValue,
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
if got := isStatefilterEmpty(tt.filter); got != tt.want {
|
|
t.Errorf("isStatefilterEmpty() = %v, want %v", got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|