mirror of
https://github.com/matrix-org/dendrite
synced 2024-11-18 07:40:53 +01:00
7d2344049d
The stale device lists table might contain entries for users we don't share a room with anymore. This now asks the roomserver about left users and removes those entries from the table. Co-authored-by: Neil Alexander <neilalexander@users.noreply.github.com>
96 lines
3.2 KiB
Go
96 lines
3.2 KiB
Go
package shared_test
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"github.com/matrix-org/dendrite/internal/sqlutil"
|
|
"github.com/matrix-org/dendrite/roomserver/storage/postgres"
|
|
"github.com/matrix-org/dendrite/roomserver/storage/shared"
|
|
"github.com/matrix-org/dendrite/roomserver/storage/sqlite3"
|
|
"github.com/matrix-org/dendrite/roomserver/storage/tables"
|
|
"github.com/matrix-org/dendrite/setup/config"
|
|
"github.com/matrix-org/dendrite/test"
|
|
"github.com/matrix-org/dendrite/test/testrig"
|
|
)
|
|
|
|
func mustCreateRoomserverDatabase(t *testing.T, dbType test.DBType) (*shared.Database, func()) {
|
|
t.Helper()
|
|
|
|
connStr, clearDB := test.PrepareDBConnectionString(t, dbType)
|
|
base, _, _ := testrig.Base(nil)
|
|
dbOpts := &config.DatabaseOptions{ConnectionString: config.DataSource(connStr)}
|
|
|
|
db, err := sqlutil.Open(dbOpts, sqlutil.NewExclusiveWriter())
|
|
assert.NoError(t, err)
|
|
|
|
var membershipTable tables.Membership
|
|
var stateKeyTable tables.EventStateKeys
|
|
switch dbType {
|
|
case test.DBTypePostgres:
|
|
err = postgres.CreateEventStateKeysTable(db)
|
|
assert.NoError(t, err)
|
|
err = postgres.CreateMembershipTable(db)
|
|
assert.NoError(t, err)
|
|
membershipTable, err = postgres.PrepareMembershipTable(db)
|
|
assert.NoError(t, err)
|
|
stateKeyTable, err = postgres.PrepareEventStateKeysTable(db)
|
|
case test.DBTypeSQLite:
|
|
err = sqlite3.CreateEventStateKeysTable(db)
|
|
assert.NoError(t, err)
|
|
err = sqlite3.CreateMembershipTable(db)
|
|
assert.NoError(t, err)
|
|
membershipTable, err = sqlite3.PrepareMembershipTable(db)
|
|
assert.NoError(t, err)
|
|
stateKeyTable, err = sqlite3.PrepareEventStateKeysTable(db)
|
|
}
|
|
assert.NoError(t, err)
|
|
|
|
return &shared.Database{
|
|
DB: db,
|
|
EventStateKeysTable: stateKeyTable,
|
|
MembershipTable: membershipTable,
|
|
Writer: sqlutil.NewExclusiveWriter(),
|
|
}, func() {
|
|
err := base.Close()
|
|
assert.NoError(t, err)
|
|
clearDB()
|
|
err = db.Close()
|
|
assert.NoError(t, err)
|
|
}
|
|
}
|
|
|
|
func Test_GetLeftUsers(t *testing.T) {
|
|
alice := test.NewUser(t)
|
|
bob := test.NewUser(t)
|
|
charlie := test.NewUser(t)
|
|
|
|
ctx := context.Background()
|
|
test.WithAllDatabases(t, func(t *testing.T, dbType test.DBType) {
|
|
db, close := mustCreateRoomserverDatabase(t, dbType)
|
|
defer close()
|
|
|
|
// Create dummy entries
|
|
for _, user := range []*test.User{alice, bob, charlie} {
|
|
nid, err := db.EventStateKeysTable.InsertEventStateKeyNID(ctx, nil, user.ID)
|
|
assert.NoError(t, err)
|
|
err = db.MembershipTable.InsertMembership(ctx, nil, 1, nid, true)
|
|
assert.NoError(t, err)
|
|
// We must update the membership with a non-zero event NID or it will get filtered out in later queries
|
|
membershipNID := tables.MembershipStateLeaveOrBan
|
|
if user == alice {
|
|
membershipNID = tables.MembershipStateJoin
|
|
}
|
|
_, err = db.MembershipTable.UpdateMembership(ctx, nil, 1, nid, nid, membershipNID, 1, false)
|
|
assert.NoError(t, err)
|
|
}
|
|
|
|
// Now try to get the left users, this should be Bob and Charlie, since they have a "leave" membership
|
|
expectedUserIDs := []string{bob.ID, charlie.ID}
|
|
leftUsers, err := db.GetLeftUsers(context.Background(), []string{alice.ID, bob.ID, charlie.ID})
|
|
assert.NoError(t, err)
|
|
assert.ElementsMatch(t, expectedUserIDs, leftUsers)
|
|
})
|
|
}
|