mirror of
https://github.com/matrix-org/dendrite
synced 2024-09-06 03:05:40 +02:00
d4918b83c6
Every time before sending a PR I like to run ./scripts/build-test-lint.sh to make sure the CI won't complain about anything. The problem is that this script attempts to install golangci-lint, which causes modifications to go.mod/go.sum. This PR backs up and restores those files before and after linting. Ideally instead of this hacky backing up/restoring we'd use go gets -mod=readonly option, but that still modifies go.sum. This will be fixed in go 1.13 apparently. golang/go#30667
36 lines
1,003 B
Bash
Executable file
36 lines
1,003 B
Bash
Executable file
#! /bin/bash
|
|
|
|
# Runs the linters against dendrite
|
|
|
|
# The linters can take a lot of resources and are slow, so they can be
|
|
# configured using the following environment variables:
|
|
#
|
|
# - `DENDRITE_LINT_CONCURRENCY` - number of concurrent linters to run,
|
|
# golangci-lint defaults this to NumCPU
|
|
# - `GOGC` - how often to perform garbage collection during golangci-lint runs.
|
|
# Essentially a ratio of memory/speed. See https://github.com/golangci/golangci-lint#memory-usage-of-golangci-lint
|
|
# for more info.
|
|
|
|
|
|
set -eux
|
|
|
|
cd `dirname $0`/..
|
|
|
|
args=""
|
|
if [ ${1:-""} = "fast" ]
|
|
then args="--fast"
|
|
fi
|
|
|
|
echo "Installing golangci-lint..."
|
|
|
|
# Make a backup of go.{mod,sum} first
|
|
# TODO: Once go 1.13 is out, use go get's -mod=readonly option
|
|
# https://github.com/golang/go/issues/30667
|
|
cp go.mod go.mod.bak && cp go.sum go.sum.bak
|
|
go get github.com/golangci/golangci-lint/cmd/golangci-lint
|
|
|
|
echo "Looking for lint..."
|
|
golangci-lint run $args
|
|
|
|
# Restore go.{mod,sum}
|
|
mv go.mod.bak go.mod && mv go.sum.bak go.sum
|