MirrorHub/forgejo
0
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-20 12:50:10 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix repo API listing stability (#12057)

Browse source 
Repo listings are paginated in the API now. Unfortunately, they are
ORDER BY updated_unix which only has second resolution. This means that
if you do a listing when multiple projects were created at the same time
you can unstable ordering. If that unstable ordering happens at a page
boundary you may fail to get a complete repo listing.

To make things worse sorting by updated_unix means that we may never get
a complete listing because udpated_unix can change independent of our
API calls.

Fix this by making the API repo listing order by id instead.
This commit is contained in:
Clark Boylan 2020-07-02 07:55:42 -07:00 committed by GitHub
parent 482ba937ed
commit 7e401fb026
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
routers/api/v1/user/repo.go
View file

@ -22,6 +22,7 @@ func listUserRepos(ctx *context.APIContext, u *models.User, private bool) {
Actor: u, Actor: u,
Private: private, Private: private,
ListOptions: opts, ListOptions: opts,
OrderBy: "id ASC",
}) })
if err != nil { if err != nil {
ctx.Error(http.StatusInternalServerError, "GetUserRepositories", err) ctx.Error(http.StatusInternalServerError, "GetUserRepositories", err)