MirrorHub/forgejo
0
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-25 07:12:44 +01:00
Code Issues Projects Releases Packages Wiki Activity

[UI] Hide consecutive additions and removals of the same label (#13315)

Browse source
This commit is contained in:
Pedro Alves 2020-10-27 07:12:01 +00:00 committed by GitHub
parent afe9d79104
commit 8e368e7065
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 25 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
routers/repo/issue.go
View file

@ -2418,11 +2418,34 @@ func combineLabelComments(issue *models.Issue) {
c.AddedLabels[0] = c.Label
}
} else {
// Remove duplicated "added" and "removed" labels
// This way, adding and immediately removing a label won't generate a comment.
var appendingTo *[]*models.Label
var other *[]*models.Label
if removingCur {
prev.RemovedLabels = append(prev.RemovedLabels, c.Label)
appendingTo = &prev.RemovedLabels
other = &prev.AddedLabels
} else {
prev.AddedLabels = append(prev.AddedLabels, c.Label)
appendingTo = &prev.AddedLabels
other = &prev.RemovedLabels
}
appending := true
for i := 0; i < len(*other); i++ {
l := (*other)[i]
if l.ID == c.Label.ID {
*other = append((*other)[:i], (*other)[i+1:]...)
appending = false
break
}
}
if appending {
*appendingTo = append(*appendingTo, c.Label)
}
prev.CreatedUnix = c.CreatedUnix
issue.Comments = append(issue.Comments[:i], issue.Comments[i+1:]...)
continue