forgejo/models/migrations
Gusted 138942c09e
[CHORE] Move test related function to own package
- Go's deadcode eliminator is quite simple, if you put a public function
in a package `aa/bb` that is used only by tests, it would still be built
if package `aa/bb` was imported. This means that if such functions use
libraries relevant only to tests that those libraries would still be
be built and increase the binary size of a Go binary.
- This is also the case with Forgejo, `models/migrations/base/tests.go`
contained functions exclusively used by tests which (skipping some steps
here) imports https://github.com/ClickHouse/clickhouse-go, which is
2MiB. The `code.gitea.io/gitea/models/migrations/base` package is
imported by `cmd/doctor` and thus the code of the clickhouse library is
also built and included in the Forgejo binary, although entirely unused
and not reachable.
- This patch moves the test-related functions to their own package, so
Go's deadcode eliminator knows not to build the test-related functions
and thus reduces the size of the Forgejo binary.
- It is not possible to move this to a `_test.go` file because Go does
not allow importing functions from such files, so any test helper
function must be in a non-test package and file.
- Reduction of size (built with `TAGS="sqlite sqlite_unlock_notify" make
build`):
  - Before: 95912040 bytes (92M)
  - After: 92306888 bytes (89M)
2024-07-14 17:00:49 +02:00
..
base [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
fixtures Remove If Exist check on migration for mssql because that syntax required SQL server 2016 (#30894) 2024-05-12 20:03:10 +02:00
test [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v1_6 Enable more revive linter rules (#30608) 2024-04-28 15:39:00 +02:00
v1_7 Rename Sync2 -> Sync (#26479) 2023-08-13 21:17:21 +02:00
v1_8 [CHORE] Remove Microsoft SQL Server Support 2024-04-05 23:37:36 +02:00
v1_9 Enable more revive linter rules (#30608) 2024-04-28 15:39:00 +02:00
v1_10 Rename Sync2 -> Sync (#26479) 2023-08-13 21:17:21 +02:00
v1_11 Enable more revive linter rules (#30608) 2024-04-28 15:39:00 +02:00
v1_12 [CHORE] Remove Microsoft SQL Server Support 2024-04-05 23:37:36 +02:00
v1_13 [CHORE] Remove Microsoft SQL Server Support 2024-04-05 23:37:36 +02:00
v1_14 [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v1_15 [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v1_16 [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v1_17 [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v1_18 [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v1_19 [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v1_20 [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v1_21 [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v1_22 [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v1_23 [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
migrations.go Prevent simultaneous editing of comments and issues (#31053) 2024-06-02 16:26:54 +02:00