mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-05 08:12:59 +01:00
e7ef94e00f
This PR follows: * #21986 * #22831 This PR also introduce customized HTML elements, which would also help problems like: * #17760 * #21429 * #21440 With customized HTML elements, there won't be any load-search-replace operations, and it can avoid page flicking (which @silverwind cares a lot). Browser support: https://developer.mozilla.org/en-US/docs/Web/API/Window/customElements # FAQ ## Why the component has the prefix? As usual, I would strongly suggest to add prefixes for our own/private names. The dedicated prefix will avoid conflicts in the future, and it makes it easier to introduce various 3rd components, like GitHub's `relative-time` component. If there is no prefix, it's impossible to introduce another public component with the same name in the future. ## Why the `custcomp.js` is loaded before HTML body? The `index.js` is after HTML body. Customized components must be registered before the content loading. Otherwise there would be still some flicking. `custcomp.js` should have its own dependencies and should be very light, so it won't affect the page loading time too much. ## Why use `data-url` attribute but not use the `textContent`? According to the standard, the `connectedCallback` occurs on the tag-opening moment. The element's children are not ready yet. ## Why not use `{{.GuessCurrentOrigin $.ctx ...}}` to let backend decide the absolute URL? It's difficult for backend to guess the correct protocol(scheme) correctly with zero configuration. Generating the absolute URL from frontend can guarantee that the URL is 100% correct -- since the user is visiting it. # Screenshot <details> ![image](https://user-images.githubusercontent.com/2114189/218256757-a267c8ba-3108-4755-9ae5-329f1b08f615.png) </details>
17 lines
741 B
JavaScript
17 lines
741 B
JavaScript
// this is a Gitea's private HTML component, it converts an absolute or relative URL to an absolute URL with the current origin
|
|
window.customElements.define('gitea-origin-url', class extends HTMLElement {
|
|
connectedCallback() {
|
|
const urlStr = this.getAttribute('data-url');
|
|
try {
|
|
// only process absolute HTTP/HTTPS URL or relative URLs ('/xxx' or '//host/xxx')
|
|
if (urlStr.startsWith('http://') || urlStr.startsWith('https://') || urlStr.startsWith('/')) {
|
|
const url = new URL(urlStr, window.origin);
|
|
url.protocol = window.location.protocol;
|
|
url.host = window.location.host;
|
|
this.textContent = url.toString();
|
|
return;
|
|
}
|
|
} catch {}
|
|
this.textContent = urlStr;
|
|
}
|
|
});
|